Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add security-txt #791

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: add security-txt #791

wants to merge 4 commits into from

Conversation

Reinis-FRP
Copy link
Contributor

@Reinis-FRP Reinis-FRP commented Dec 5, 2024

Adds security.txt to svm-spoke and multicall-handler programs.

Signed-off-by: Reinis Martinsons <[email protected]>
Signed-off-by: Reinis Martinsons <[email protected]>
Signed-off-by: Reinis Martinsons <[email protected]>
@@ -31,4 +31,3 @@ storage-layouts/proposed*
target
**/*.rs.bk
test-ledger
idls
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

External IDLs are fetched locally on build, but we need them posted in the repo as solana-verify verify-from-repo would depend on them

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense. we'll need to figure out how we want to package stuff such that it fits within the current across-contracts package. This'll be the ./target/type/svm_spoke.ts type exports.

I think we'd want to include the programs within this export, just like the ts package has the contracts within it.

@Reinis-FRP Reinis-FRP requested review from chrismaree and md0x December 5, 2024 15:43
@Reinis-FRP Reinis-FRP marked this pull request as ready for review December 5, 2024 15:44
Copy link
Contributor

@md0x md0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes ACX-3480

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants