Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(svm): Refactor deposit ID to use big-endian encoding in Bytes32 format #810

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat(svm): Refactor deposit ID to use big-endian encoding in Bytes32 format #810

wants to merge 4 commits into from

Conversation

md0x
Copy link
Contributor

@md0x md0x commented Dec 19, 2024 •
edited
Loading

Changes proposed in this PR:

  • Updated deposit ID storage format to use big-endian encoding
  • Refactored byte manipulation logic to ensure consistent big-endian encoding and decoding for 32byte arrays

md0x added 4 commits December 19, 2024 13:25
@md0x
feat(svm): store safe deposit id as be
f570b71 
Signed-off-by: Pablo Maldonado <[email protected]>
@md0x
test: add bg conversion and test
b4836f4 
Signed-off-by: Pablo Maldonado <[email protected]>
@md0x
refactor: conversion utils comment
b97acd8 
Signed-off-by: Pablo Maldonado <[email protected]>
@md0x
refactor: simplify
739fb03 
Signed-off-by: Pablo Maldonado <[email protected]>
@md0x md0x changed the title Pablo/deposit id encoding feat(svm): Refactor deposit ID to use big-endian encoding in Bytes32 format Dec 19, 2024
@md0x md0x marked this pull request as ready for review December 19, 2024 14:37
Reinis-FRP
Reinis-FRP approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@Reinis-FRP Reinis-FRP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, this should be easier for offchain to work with

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reinis-FRP Reinis-FRP Reinis-FRP approved these changes

@chrismaree chrismaree Awaiting requested review from chrismaree

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@md0x @Reinis-FRP