Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: periphery deploy scripts and deployments #812

Open
wants to merge 7 commits into
base: spokepool-periphery-multiple-exchanges
Choose a base branch
from

Conversation

bmzig
Copy link
Contributor

@bmzig bmzig commented Dec 19, 2024

  • Create2Factory should be deployed on each chain which we anticipate holding a periphery. They only need to be deployed once and we can reuse the same factory from that point onward.
  • SpokePoolPeripheryProxy should then be deployed next. This cannot be done with Create2Factory since its init code requires knowledge of the SpokePoolV3Periphery deployment, which is yet to be deployed.
  • SpokePoolV3Periphery should be deployed last, which should be done with Create2Factory.
  • Finally, we can initialize SpokePoolPeripheryProxy. Note that if the initialization is done improperly on either of the two contracts, we need to redeploy both contracts, since we cannot update the contract address definitions once they are initialized.

@bmzig bmzig marked this pull request as ready for review December 23, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant