Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Added tests for Base_SpokePool.sol #818

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Dhruv-Varshney-developer

Description

  • Base_SpokePool.sol lacked test coverage, which could lead to potential issues. This PR ensures that the functionality is well-tested and behaves as expected. Additionally, small improvements to the documentation enhance clarity and professionalism, while ESLint warning adjustments streamline development.

Code Changes Overview:

  1. Added tests in test/evm/hardhat/chain-specific-spokepools/Base_SpokePool.ts, covering initialization and error scenarios.
  2. Disabled specific ESLint warnings in some files to prevent unnecessary noise during development.
  3. Modified README.md for spelling corrections and slight formatting improvements.

Please let me know if improvements are needed in the PR!

You can learn more about me here.

@Dhruv-Varshney-developer Dhruv-Varshney-developer marked this pull request as draft December 21, 2024 19:34
@Dhruv-Varshney-developer Dhruv-Varshney-developer marked this pull request as ready for review December 21, 2024 19:35
Signed-off-by: Dhruv-Varshney-Developer <[email protected]>
Signed-off-by: Dhruv-Varshney-Developer <[email protected]>
Signed-off-by: Dhruv-Varshney-Developer <[email protected]>
Signed-off-by: Dhruv-Varshney-Developer <[email protected]>
Signed-off-by: Dhruv-Varshney-Developer <[email protected]>
Signed-off-by: Dhruv-Varshney-Developer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant