fix: script to fill jupiter swap #819
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Reinis Martinsons <[email protected]>
Signed-off-by: Reinis Martinsons <[email protected]>
Signed-off-by: Reinis Martinsons <[email protected]>
Signed-off-by: Reinis Martinsons <[email protected]>
Reinis-FRP
commented
Dec 23, 2024
| @@ -76,5 +116,33 @@ export async function sendTransactionWithLookupTable( | |||
| versionedTx.sign([sender]); | |||
| const txSignature = await connection.sendTransaction(versionedTx); | |||
|
|
|||
| return { txSignature, lookupTableAddress }; | |||
| // Confirm the versioned transaction | |||
| await confirmTransaction(connection, txSignature); | |||
There was a problem hiding this comment.
This might conflict once #811 is merged in, but seems better to have reusable transaction confirmation helper
Reinis-FRP
commented
Dec 23, 2024
There was a problem hiding this comment.
This has some overlaps from #811 as we needed better tx confirmation for filling across+
Signed-off-by: Reinis Martinsons <[email protected]>
Reinis-FRP
commented
Dec 23, 2024
Comment on lines
+49
to
+52
| const svmSpokeIdl = require("../../target/idl/svm_spoke.json"); | ||
| const svmSpokeProgram = new Program<SvmSpoke>(svmSpokeIdl, provider); | ||
| const handlerIdl = require("../../target/idl/multicall_handler.json"); | ||
| const handlerProgram = new Program<MulticallHandler>(handlerIdl, provider); |
There was a problem hiding this comment.
might want to simplify this once #806 is in
Reinis-FRP
commented
Dec 23, 2024
There was a problem hiding this comment.
not related to this PR, but linter picked these up
Reinis-FRP
commented
Dec 23, 2024
There was a problem hiding this comment.
We might also consider passing priority fees to loadExecuteRelayerRefundLeafParams, but that would require some refactor not directly related to this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a script to test Across+ fills with Jupiter swap integration on mainnet. Note that all remaining tokens above minimum output amount can be stolen by anyone. This could be improved by either creating a sweeper program that reads actual handler ATA balance and transfers all of them to the recipient ATA or building this functionality in the Multicall handler.
Tested on below mainnet deployments: