refactor: add rpc logs flag #1182
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pxrl
approved these changes
Sep 5, 2024
| @@ -746,7 +747,7 @@ function getProviderFromConfigJson(_chainId: string) { | |||
| 500, // delay | |||
| 5, // max. concurrency | |||
| "QUOTES_API", // cache namespace | |||
| 0 // disable RPC calls logging | |||
| ENABLE_RPC_LOGS === "true" ? 100 : 0 | |||
There was a problem hiding this comment.
Is it worth making this env var a number of range [0, 100]? Toggling to 100 might be like trying to drink from the firehose in a situation where other things might already be going wrong, and it might have an undesirable performance impact. In the bots we run w/ 1% or something like that, but it's nice to be able to tune it.
There was a problem hiding this comment.
+1 - this makes to include a way to configure the logging in a more granular way
|
Is this still in flight? cc @dohaki |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to push before merging in the context of #1180 (comment)