feat: /swap endpoint
#1269
Draft
feat: /swap endpoint
#1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
* feat: add exact output trade type support uniswap * test with base * fixup * fixup * fixup * ci: fix dep review * fixup * test uniswap universal * fixup * test 1inch * fixup * fixup
pxrl
reviewed
Nov 13, 2024
pxrl
reviewed
Nov 13, 2024
There was a problem hiding this comment.
Do we want to add Mainnet, Blast, World Chain & Zora here?
There was a problem hiding this comment.
ooc, do we have a merge-time check that this file matches 1:1 the output of the generate-routes script? I could see how they could accidentally get out of sync on a long-running PR.
There was a problem hiding this comment.
no we don't... we should add that to CI
Yea this branch is supposed to be the long-living epic branch actually. That's why I am keeping it in a draft state for now |
* feat: cross swap quotes resolve uniswap min output * add test script * refine min output and leftover tokens handling
* resolve arbitrary token details * fixup * use wrapped addresses to resolve native tokens * create error class, refactor using multicall * Update api/_utils.ts Co-authored-by: Dong-Ha Kim <[email protected]> * validate inputs, add cause to error --------- Co-authored-by: Dong-Ha Kim <[email protected]>
* feat: build cross swap tx * fixup * fixup * refactor * fix * fixup * fixup * feat: add leftover handling type * fixup * fixup * review requests
* feat: build cross swap tx * fixup * fixup * refactor * fix * fixup * fixup * feat: add leftover handling type * fixup * fixup * feat: support native eth as input/output * review requests * refactor leftover type into exact_output and min_output for clarity * add temp swap and bridge typechain binding and use for testing * fixup
* add utility for parsing query params with coercion for non string values * extend api to accept tokenAdress & chainId * bump sdk version * bump sdk, fix build error * small refactor * update sdk
* update sdk * measure by input type * measure by cross swap type * measure full run of endpoint * use console instance without global loglevel restriction * remove unnecessary awaits
* perf: only use indicative quotes * add profiling * add caching of indicative quotes * fixup * fixup * fixup * fixup * add more profiling
* feat: support permit swap * fixup * refactor: swap test scripts * wip * feat: refactor + support permit * fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epic branch for /swap endpoint