Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add aleph zero #499

Merged

Conversation

melisaguevara
Copy link

No description provided.

Copy link

linear bot commented Nov 1, 2024

startBlockNumber: 4112376,
abi: JSON.stringify(SpokePoolV3Abi),
acrossVersion: AcrossContractsVersion.V3,
firstDepositId: 0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this fit with the deploy we made?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is firstDepositId 0 or 1?

Copy link
Author

@melisaguevara melisaguevara Nov 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this fit with the deploy we made?

Yes, do you see any differences? @james-a-morris

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is firstDepositId 0 or 1?

We set it to 0, here. The first item of initArgs is the initialDepositId

Copy link
Collaborator

@amateima amateima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to do anything about the step no3 from here?

startBlockNumber: 4112376,
abi: JSON.stringify(SpokePoolV3Abi),
acrossVersion: AcrossContractsVersion.V3,
firstDepositId: 0,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is firstDepositId 0 or 1?

@melisaguevara
Copy link
Author

Do we need to do anything about the step no3 from here?

Uh I missed that. I've set the same value that we use for arbitrum here 9ca3de7

Copy link
Contributor

@james-a-morris james-a-morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending @amateima's signoff

@amateima amateima merged commit 7453d39 into master Nov 13, 2024
2 checks passed
@amateima amateima deleted the mguevara/acx-2765-update-scraper-api-to-start-consuming-events branch November 13, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants