improve(retryProvider): Avoid retry on eth_call reverts #757
+31
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eth_call requests where the provider returns a response indicating revert have a near-zero chance of succeeding against another RPC provider. Instead of wasting time rotating through the list of RPC providers, just throw immediately and let the upper layers handle it. This will potentially save quite a bit of time in the relayer in cases where it unsuccessfully performs a static call to determine whether a fill would complete.
pxrl
commented
Oct 25, 2024
| // Most node implementations return 3 for an eth_call revert, but some return -32000. | ||
| // See also https://www.jsonrpc.org/specification | ||
| if (code < -32768 || code > -32100) { | ||
| if (method === "eth_call" && message.toLowerCase().includes("revert")) { |
There was a problem hiding this comment.
This could maybe also be conditional on quorumThreshold === 1.
pxrl
commented
Oct 25, 2024
There was a problem hiding this comment.
Still todo after discussion w/ @mrice32: update _trySend() such that it can identify a revert on an eth_call and short-circuit the retry loop that is inevitably occurring. This would shave off at least 3+ seconds per call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eth_call requests where the provider returns a response indicating revert have a near-zero chance of succeeding against another RPC provider. Instead of wasting time rotating through the list of RPC providers, just throw immediately and let the upper layers handle it.
This will potentially save quite a bit of time in the relayer in cases where it unsuccessfully performs a static call to determine whether a fill would complete.