Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding code overage for java projects #291

Open
wants to merge 39 commits into
base: master
Choose a base branch
from
Open

Conversation

epatotski
Copy link

Added:

  1. Code overage for java projects
  2. Agregated coverage report

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

1. Code overage for java projects
2. Agregated coverage report
Copy link

Hello @epatotski 😄

Thank you so much for opening a pull request!

Image
You can check out your contributor card and see all your past stats here!

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 71.91781% with 164 lines in your changes missing coverage. Please review.

Project coverage is 74.83%. Comparing base (df564b0) to head (0113e35).
Report is 44 commits behind head on master.

Files with missing lines Patch % Lines
...ta-ingestion/src/datahub/utilities/search_utils.py 65.31% 60 Missing ⚠️
...ngestion/source/bigquery_v2/bigquery_schema_gen.py 45.09% 28 Missing ⚠️
...a-ingestion/src/datahub/utilities/openapi_utils.py 38.46% 16 Missing ⚠️
...api/entities/platformresource/platform_resource.py 71.11% 13 Missing ⚠️
...e/bigquery_v2/bigquery_platform_resource_helper.py 83.07% 11 Missing ⚠️
metadata-ingestion/src/datahub/cli/check_cli.py 18.18% 9 Missing ⚠️
...src/datahub/ingestion/source/redshift/exception.py 0.00% 4 Missing ⚠️
.../src/datahub/ingestion/source/redshift/redshift.py 0.00% 4 Missing ⚠️
...ub/ingestion/source/snowflake/snowflake_queries.py 71.42% 4 Missing ⚠️
.../src/datahub/ingestion/source/fivetran/fivetran.py 71.42% 2 Missing ⚠️
... and 11 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #291      +/-   ##
==========================================
+ Coverage   74.43%   74.83%   +0.39%     
==========================================
  Files         590      590              
  Lines       58010    58135     +125     
==========================================
+ Hits        43181    43503     +322     
+ Misses      14829    14632     -197     
Flag Coverage Δ
airflow 64.52% <ø> (ø)
airflow-plugin-v1 40.87% <ø> (ø)
airflow-plugin-v2 56.67% <ø> (ø)
prefect ?
prefect- ?
pytest-testIntegrationBatch0 60.61% <57.02%> (+0.34%) ⬆️
pytest-testIntegrationBatch1 38.93% <36.30%> (+0.16%) ⬆️
pytest-testIntegrationBatch2 41.67% <41.78%> (-0.83%) ⬇️
pytest-testQuick 46.04% <51.88%> (+0.63%) ⬆️
test-airflow24 55.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

david-leifker and others added 23 commits October 22, 2024 19:57
hsheth2 and others added 15 commits October 22, 2024 19:57

- name: Get and Format Username (PR only)
if: github.event_name == 'pull_request'
run: |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:2:50: Double quote to prevent globbing and word splitting [shellcheck]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2129:style:2:1: Consider using { cmd1; cmd2; } >> file instead of individual redirects [shellcheck]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[actionlint] reported by reviewdog 🐶
property "integrations_service_change" is not defined in object type {backend_change: string; backend_only: string; branch_name: string; docker-login: string; elasticsearch_setup_change: string; frontend_change: string; frontend_only: string; full_tag: string; ingestion_base_change: string; ingestion_change: string; ingestion_only: string; kafka_setup_change: string; mysql_setup_change: string; postgres_setup_change: string; pr-publish: string; publish: string; python_release_version: string; repository_name: string; slim_tag: string; smoke_test_change: string; tag: string; unique_full_tag: string; unique_slim_tag: string; unique_tag: string} [expression]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[actionlint] reported by reviewdog 🐶
property "short_sha" is not defined in object type {backend_change: string; backend_only: string; branch_name: string; docker-login: string; elasticsearch_setup_change: string; frontend_change: string; frontend_only: string; full_tag: string; ingestion_base_change: string; ingestion_change: string; ingestion_only: string; kafka_setup_change: string; mysql_setup_change: string; postgres_setup_change: string; pr-publish: string; publish: string; python_release_version: string; repository_name: string; slim_tag: string; smoke_test_change: string; tag: string; unique_full_tag: string; unique_slim_tag: string; unique_tag: string} [expression]

message: '{ "command": "git-sync", "args" : {"repoName": "${{ needs.setup.outputs.repository_name }}", "repoOrg": "${{ github.repository_owner }}", "repoBranch": "${{ needs.setup.outputs.branch_name }}", "repoShaShort": "${{ needs.setup.outputs.short_sha }}" }}'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.