Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mongoid compatibility. #182

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ryanfox1985
Copy link

No description provided.

@coveralls
Copy link

coveralls commented Apr 12, 2020

Coverage Status

Coverage decreased (-6.3%) to 91.606% when pulling 497282f on ryanfox1985:feature/mongoid_compatibility into 07cee9c on activeadmin-plugins:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 97.681% when pulling 9330497 on ryanfox1985:feature/mongoid_compatibility into 07cee9c on activeadmin-plugins:master.

@ryanfox1985 ryanfox1985 force-pushed the feature/mongoid_compatibility branch from ec48635 to 4419b68 Compare April 16, 2020 22:22
@@ -139,12 +142,21 @@ def run_callback(name)
end

def batch_import
@resource.respond_to?(:transaction) ? batch_improt_with_transaction : batch_import_without_transaction

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@resource.respond_to?(:transaction) ? batch_improt_with_transaction : batch_import_without_transaction
@resource.respond_to?(:transaction) ? batch_import_with_transaction : batch_import_without_transaction

batch_result
end

def batch_improt_with_transaction

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def batch_improt_with_transaction
def batch_import_with_transaction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants