Allow disabling TLS certificate verification #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plajjan
force-pushed
the
1471-tls-disable-verification
branch
2 times, most recently
from
c2aa956
to
4f8676c
Compare
This is obviously not a good security practice but for the sake of testing or similar it is very useful to be able to disable the verification of TLS certificates. Most of the changes went into the tlsuv library where I had to add new options for this. I'm not all too pleased with that solution but it works. I have verified that this works by connecting to google.com but through an IP address so we get a mismatch between the address and certificate name. It normally fails but once we disable verification the connection is established.
These fields should always be initialized and I have now fixed that in tlsuv_stream_init inside of tlsuv instead.
plajjan
force-pushed
the
1471-tls-disable-verification
branch
from
4f8676c
to
f570b94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is obviously not a good security practice but for the sake of testing or similar it is very useful to be able to disable the verification of TLS certificates.
Most of the changes went into the tlsuv library where I had to add new options for this. I'm not all too pleased with that solution but it works.
I have verified that this works by connecting to google.com but through an IP address so we get a mismatch between the address and certificate name. It normally fails but once we disable verification the connection is established.
Fixes #1471