Allow naming overlap for hierarchical modules #1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having a module foo (src/foo.act) and a foo.bar (src/foo/bar.act) would previously "conflict" and lead to a compilation error. We now allow it. We should really have some more checks around this to ensure that there are no true conflicts, i.e. that the module foo does not define any "bar", since the foo.bar is now a module... but that's for later ;) Meanwhile, one needs to be careful :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a module foo (src/foo.act) and a foo.bar (src/foo/bar.act) would previously "conflict" and lead to a compilation error. We now allow it. We should really have some more checks around this to ensure that there are no true conflicts, i.e. that the module foo does not define any "bar", since the foo.bar is now a module... but that's for later ;) Meanwhile, one needs to be careful :)
Fixes #1657