added method pop to protocol Mapping and dict implementation #1986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The required check test-app-yang fails and prevents the merging of this PR which would fix issue #1989. I don't know what the problem is. |
|
@sydow yeah, FYI I also had to rerun the tests after clearing the cache first for them to pass successfully on this repo first. But yes, it fails on some of these apps... I presume it is because the return type has changed. I can look into that! |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds method pop to protocol Mapping and the dict implementation. Also a minor change to method get. The signatures are
get : (A,?B) -> ?B
pop : mut(A,?B) -> ?B