Add DANSKEBANK_DABANO22 integration (#244)

src/app-gocardless/bank-factory.js

@@ -5,6 +5,7 @@ import MbankRetailBrexplpw from './banks/mbank-retail-brexplpw.js';
 import NorwegianXxNorwnok1 from './banks/norwegian-xx-norwnok1.js';
 import SandboxfinanceSfin0000 from './banks/sandboxfinance-sfin0000.js';
 import FintroBeGebabebb from './banks/fintro-be-gebabebb.js';
+import DanskeBankDabNO22 from './banks/danskebank-dabno22.js';
 
 const banks = [
   AmericanExpressAesudef1,
@@ -13,6 +14,7 @@ const banks = [
   SandboxfinanceSfin0000,
   NorwegianXxNorwnok1,
   FintroBeGebabebb,
+  DanskeBankDabNO22,
 ];
 
 export default (institutionId) =>

src/app-gocardless/banks/danskebank-dabno22.js

@@ -0,0 +1,60 @@
+import {
+  printIban,
+  amountToInteger,
+  sortByBookingDateOrValueDate,
+} from '../utils.js';
+
+/** @type {import('./bank.interface.js').IBank} */
+export default {
+  institutionIds: ['DANSKEBANK_DABANO22'],
+
+  normalizeAccount(account) {
+    return {
+      account_id: account.id,
+      institution: account.institution,
+      mask: account.iban.slice(-4),
+      iban: account.iban,
+      name: [account.name, printIban(account)].join(' '),
+      official_name: account.name,
+      type: 'checking',
+    };
+  },
+
+  normalizeTransaction(transaction, _booked) {
+    /**
+     * Danske Bank appends the EndToEndID: NOTPROVIDED to
+     * remittanceInformationUnstructured, cluttering the data.
+     *
+     * We clean thais up by removing any instances of this string from all transactions.
+     *
+     */
+    transaction.remittanceInformationUnstructured =
+      transaction.remittanceInformationUnstructured.replace(
+        '\nEndToEndID: NOTPROVIDED',
+        '',
+      );
+
+    /**
+     * The valueDate in transactions from Danske Bank is not the one expected, but rather the date
+     * the funds are expected to be paid back for credit accounts.
+     */
+    return {
+      ...transaction,
+      date: transaction.bookingDate,
+    };
+  },
+
+  sortTransactions(transactions = []) {
+    return sortByBookingDateOrValueDate(transactions);
+  },
+
+  calculateStartingBalance(sortedTransactions = [], balances = []) {
+    const currentBalance = balances.find(
+      (balance) => balance.balanceType === 'interimAvailable',
+    );
+
+    return sortedTransactions.reduce((total, trans) => {
+      return total - amountToInteger(trans.transactionAmount.amount);
+    }, amountToInteger(currentBalance.balanceAmount.amount));
+  },
+};

upcoming-release-notes/244.md

@@ -0,0 +1,6 @@
+---
+category: Enhancements
+authors: [LudvigHz]
+---
+
+Add GoCardless integration for Danske Bank Private NO