♻️ rename nordigen to gocardless #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-f1
reviewed
Jul 23, 2023
| /// Migrates nordigen from config.json or process.env to app secret | ||
| migrateNordigen() { | ||
| /// Migrates GoCardless from config.json or process.env to app secret | ||
| migrateGoCardless() { | ||
| if ( | ||
| config.nordigen && | ||
| (!this.get(SecretName.nordigen_secretId) || |
There was a problem hiding this comment.
What do you want to do about the secret names? Would it make sense to migrate them to gocardless_*?
There was a problem hiding this comment.
Yea, I'd like to do this, but separately. It's a non-trivial operation to do this with backwards compatibility both in the UI and API layer.
j-f1
approved these changes
Jul 23, 2023
trafico-bot
bot
added
✅ Approved
trafico-bot
bot
added
✨ Merged
MMichotte
pushed a commit
to MMichotte/actual-server
that referenced
this pull request
Sep 9, 2024
Just renaming things from Nordigen to Gocardless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just renaming things from Nordigen to Gocardless.