Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GoCardless bank integration for American Express AESUDEF1 #239

Merged

Conversation

kyrias
Copy link
Contributor

@kyrias kyrias commented Aug 5, 2023

The first commit has the same transaction normalization commit as #237.

@kyrias kyrias force-pushed the gocardless-american-express-aesudef1 branch from c78bb08 to 3dca17e Compare August 8, 2023 21:04
Copy link
Member

@MatissJanis MatissJanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea of adding normalizeTransaction. That will be useful.

As for the specific american express bank integration: rubber stamp approval there as I don't use this bank myself.

@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review labels Aug 9, 2023
@MatissJanis MatissJanis merged commit 9c9f664 into actualbudget:master Aug 9, 2023
6 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved Pull Request has been approved and can be merged labels Aug 9, 2023
@kyrias kyrias deleted the gocardless-american-express-aesudef1 branch August 9, 2023 14:09
MMichotte pushed a commit to MMichotte/actual-server that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants