-
-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docker-release.yml to tag images with all semver levels #373
Conversation
Add tags for all semver levels (major, major.minor, and major.minor.patch) to the release docker images. This allows users to specify a higher level tag when pulling and updating images; users can choose something more stable than `latest` without having to lock to a specific M.m.p
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
not stale, waiting on review. |
Would there be a use case to lock to, say, version 23.x.x when 23.12.0 has just as much in common with 24.1.0 as it does with 23.11.0? Since the version scheme is year.month.patch |
lol, It had not clicked with me that it is I'll leave this PR around if maintainers want to merge it, and if not just let the bot close as stale. |
@jhollowe the |
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
This is ready to be reviewed and merged |
type=semver,pattern={{major}}.{{minor}}.{{patch}} | ||
type=semver,pattern={{major}}.{{minor}} | ||
type=semver,pattern={{major}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type=semver,pattern={{major}}.{{minor}}.{{patch}} | |
type=semver,pattern={{major}}.{{minor}} | |
type=semver,pattern={{major}} | |
type=semver,pattern={{version}} | |
type=semver,pattern={{major}}.{{minor}} |
@jhollowe we decided we didn't need the major only tag, so let's go ahead and drop it, and just keep your other changes.
WalkthroughThe pull request introduces modifications to the Docker image tagging strategy within the GitHub Actions workflow configuration. The previous setup used a single semantic versioning tag pattern, while the updated configuration adds multiple patterns for tagging, including major, minor, and patch versions. This enhancement allows for a more detailed representation of image versions in accordance with semantic versioning principles. Changes
Recent review detailsConfiguration used: CodeRabbit UI Files ignored due to path filters (1)
Files selected for processing (1)
Additional comments not posted (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
This PR was closed because it has been stalled for 5 days with no activity. |
Add tags for all semver levels (major, major.minor, and major.minor.patch) to the release docker images. This allows users to specify a higher level tag when pulling and updating images; users can choose something more stable than
latest
without having to lock to a specific M.m.p