Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker-release.yml to tag images with all semver levels #373

Closed
wants to merge 5 commits into from

Conversation

jhollowe
Copy link

Add tags for all semver levels (major, major.minor, and major.minor.patch) to the release docker images. This allows users to specify a higher level tag when pulling and updating images; users can choose something more stable than latest without having to lock to a specific M.m.p

Add tags for all semver levels (major, major.minor, and major.minor.patch) to the release docker images.
This allows users to specify a higher level tag when pulling and updating images; users can choose something more stable than `latest` without having to lock to a specific M.m.p
Copy link
Contributor

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale label Jul 17, 2024
@jhollowe
Copy link
Author

not stale, waiting on review.

@youngcw
Copy link
Member

youngcw commented Jul 17, 2024

Would there be a use case to lock to, say, version 23.x.x when 23.12.0 has just as much in common with 24.1.0 as it does with 23.11.0? Since the version scheme is year.month.patch

@jhollowe
Copy link
Author

jhollowe commented Aug 2, 2024

lol, It had not clicked with me that it is year.month.patch; I guess this isn't really needed.

I'll leave this PR around if maintainers want to merge it, and if not just let the bot close as stale.

@twk3
Copy link
Contributor

twk3 commented Aug 2, 2024

@jhollowe the type=semver,pattern={{major}}.{{minor}} is likely still worth adding if you want to update this PR. It was lost during a previous change even though the comment still indicates we have it.

Copy link
Contributor

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale label Sep 10, 2024
@jhollowe
Copy link
Author

This is ready to be reviewed and merged

Comment on lines +24 to +26
type=semver,pattern={{major}}.{{minor}}.{{patch}}
type=semver,pattern={{major}}.{{minor}}
type=semver,pattern={{major}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type=semver,pattern={{major}}.{{minor}}.{{patch}}
type=semver,pattern={{major}}.{{minor}}
type=semver,pattern={{major}}
type=semver,pattern={{version}}
type=semver,pattern={{major}}.{{minor}}

@jhollowe we decided we didn't need the major only tag, so let's go ahead and drop it, and just keep your other changes.

Copy link
Contributor

coderabbitai bot commented Sep 19, 2024

Walkthrough

The pull request introduces modifications to the Docker image tagging strategy within the GitHub Actions workflow configuration. The previous setup used a single semantic versioning tag pattern, while the updated configuration adds multiple patterns for tagging, including major, minor, and patch versions. This enhancement allows for a more detailed representation of image versions in accordance with semantic versioning principles.

Changes

Files Change Summary
.github/workflows/docker-release.yml Updated the TAGS configuration to include additional semantic versioning patterns for tagging:
- Changed from type=semver,pattern={{version}} to:
- type=semver,pattern={{major}}.{{minor}}.{{patch}}
- type=semver,pattern={{major}}.{{minor}}
- type=semver,pattern={{major}}

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between fe85325 and 0a41a7c.

Files ignored due to path filters (1)
  • upcoming-release-notes/373.md is excluded by !**/*.md
Files selected for processing (1)
  • .github/workflows/docker-release.yml (1 hunks)
Additional comments not posted (1)
.github/workflows/docker-release.yml (1)

20-26: Consider removing the major-only tag based on past review comments.

The additional tag patterns {{major}}.{{minor}}.{{patch}} and {{major}}.{{minor}} provide more flexibility in versioning and allow users to pull images using higher-level tags, which is a useful enhancement.

However, based on the past review comments, it was decided that the major-only tag is not needed. Consider removing the following line to align with the previous decision:

-    type=semver,pattern={{major}}

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale label Oct 20, 2024
Copy link
Contributor

This PR was closed because it has been stalled for 5 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants