Add support for Bizum transactions in Revolut

[hostyn]

In Spain, we have a protocol called Bizum that allows instant transactions via phone number. Revolut recently added support for these transactions, but the information displayed for them was a bit messy.

I fixed this by adding a Revolut integration, only modifying the Bizum transactions, as all other transactions were displayed correctly. I also added tests for these transactions.

Additionally, I fixed the transaction type, which was using proprietaryBank instead of proprietaryBankTransactionCode. As you can see here, this seems like an error. I didn't find any reference to proprietaryBank in the code but did find some for proprietaryBankTransactionCode, so this definitely looks like a mistake.

I found this error because I initially intended to use proprietaryBankTransactionCode, but in the end, it wasn't necessary.

[coderabbitai]

Walkthrough

This pull request introduces the RevolutRevolt21 module to the application, enhancing the handling of bank transactions specifically for Revolut. It includes a new method for normalizing transactions related to Bizum payments while retaining fallback integration logic. Additionally, the type definition for the Transaction type is updated by renaming a property for clarity. Unit tests for the new module are also added to ensure proper functionality.

Changes

File	Change Summary
src/app-gocardless/bank-factory.js	Updated imports and modified the banks array to include NbgEthngraaxxx, RevolutRevolt21, and SandboxfinanceSfin0000, while removing duplicates and expanding the BANKS_WITH_LIMITED_HISTORY array.
src/app-gocardless/banks/revolut_revolt21.js	Introduced a new module for handling Revolut transactions, including a normalizeTransaction method for Bizum payments.
src/app-gocardless/banks/tests/revolut_revolt21.spec.js	Added unit tests for the normalizeTransaction method, validating its functionality for Bizum expense and income transfers.
src/app-gocardless/gocardless-node.types.ts	Renamed property proprietaryBank to proprietaryBankTransactionCode in the Transaction type definition.

Possibly related PRs

• Fix pending transaction amount sign and payee name for National Bank of Greece import #448: The addition of the RevolutRevolt21 module in the main PR is similar to the addition of the NbgEthngraaxxx module in PR Fix pending transaction amount sign and payee name for National Bank of Greece import #448, as both involve expanding the banks array in src/app-gocardless/bank-factory.js to include new bank entities.

Suggested labels

:sparkles: Merged

Suggested reviewers

• MatissJanis

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[matt-fidd]

Thanks for this! One tiny nit before I can approve

[hostyn]

Now it is in alphabetical order 😁

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (3)

src/app-gocardless/bank-factory.js (3)

48-51: Consider maintaining alphabetical order in the banks array.

The new entries have been added to the banks array correctly. However, to improve readability and maintainability, consider moving RevolutRevolt21 before SandboxfinanceSfin0000 to maintain strict alphabetical order.

Suggested change:

  NbgEthngraaxxx,
  NorwegianXxNorwnok1,
  RevolutRevolt21,
- SandboxfinanceSfin0000,
+ RevolutRevolt21,
+ SandboxfinanceSfin0000,

---

65-81: Maintain strict alphabetical order in BANKS_WITH_LIMITED_HISTORY.

The new entries in the BANKS_WITH_LIMITED_HISTORY array are consistent with the existing naming convention. However, to improve readability and maintainability, consider reordering the entries to maintain strict alphabetical order.

Suggested reordering:

export const BANKS_WITH_LIMITED_HISTORY = [
  'BANCA_AIDEXA_AIDXITMM',
  'BANCA_PATRIMONI_SENVITT1',
  'BANCA_SELLA_SELBIT2B',
  'BANKINTER_BKBKESMM',
  'BBVA_BBVAESMM',
  'BRED_BREDFRPPXXX',
  'CAIXABANK_CAIXESBB',
  'CARTALIS_CIMTITR1',
  'CESKA_SPORITELNA_LONG_GIBACZPX',
  'COOP_EKRDEE22',
  'DOTS_HYEEIT22',
  'HYPE_BUSINESS_HYEEIT22',
  'HYPE_HYEEIT2',
  'ILLIMITY_ITTPIT2M',
  'INDUSTRA_MULTLV2X',
  'JEKYLL_JEYKLL002',
  'LABORALKUTXA_CLPEES2M',
  // ... (rest of the array)
];

---

89-100: Maintain alphabetical order for all entries in BANKS_WITH_LIMITED_HISTORY.

The new entries at the end of the BANKS_WITH_LIMITED_HISTORY array are consistent with the existing naming convention. However, to improve readability and maintainability, consider reordering all entries in the array to maintain strict alphabetical order.

Suggested action:
Reorder all entries in the BANKS_WITH_LIMITED_HISTORY array alphabetically, including both existing and new entries.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 268d3ac and 58d75c3.

📒 Files selected for processing (1)

• src/app-gocardless/bank-factory.js (2 hunks)

🔇 Additional comments (2)

src/app-gocardless/bank-factory.js (2)

19-22: LGTM: New imports added correctly.

The new imports for NbgEthngraaxxx, RevolutRevolt21, and SandboxfinanceSfin0000 have been added consistently with the existing import style and maintain alphabetical order.

---

85-87: LGTM: Entries removed from BANKS_WITH_LIMITED_HISTORY.

The removal of 'LUMINOR_NDEALT2X' and 'LUMINOR_RIKOEE22' from the BANKS_WITH_LIMITED_HISTORY array appears intentional and doesn't disrupt the array structure.

[matt-fidd]

Amazing, thank you!