[WIP] Add "Boursorama Bank" (FR) to list of banks

[bakoff44]

Importing datas with default integration, will insert unwanted datas in operation names.
This PR is done to ignore theses data when imported from GoCardless

[coderabbitai]

Walkthrough

The pull request introduces changes to the src/app-gocardless/bank-factory.js file, including the removal of two bank imports and the addition of Boursorama. The BANKS_WITH_LIMITED_HISTORY array is updated by removing two entries. Additionally, a new module for Boursorama bank integration is created, featuring a method for normalizing transaction data.

Changes

File	Change Summary
src/app-gocardless/bank-factory.js	Removed imports for BancsabadellBsabesbb and CBCcregbebb, added Boursorama, updated banks array and BANKS_WITH_LIMITED_HISTORY.
src/app-gocardless/banks/BOURSORAMA_BOUSFRPP.js	Added a new module for Boursorama bank integration, including the normalizeTransaction method.

Possibly related PRs

• Fix pending transaction amount sign and payee name for National Bank of Greece import #448: This PR modifies the src/app-gocardless/bank-factory.js file by adding a new bank entity to the banks array, which is directly related to the changes made in the main PR that also involves modifications to the same file and the banks array.

Suggested reviewers

• MatissJanis

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 50a3db7 and b2c7821.

Files ignored due to path filters (1)

• upcoming-release-notes/463.md is excluded by !**/*.md

Files selected for processing (1)

• src/app-gocardless/bank-factory.js (2 hunks)

Files skipped from review as they are similar to previous changes (1)

• src/app-gocardless/bank-factory.js

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c01e229 and 50a3db7.

Files selected for processing (2)

• src/app-gocardless/bank-factory.js (2 hunks)
• src/app-gocardless/banks/BOURSORAMA_BOUSFRPP.js (1 hunks)

Additional comments not posted (3)

src/app-gocardless/bank-factory.js (2)

Line range hint 53-94: Clarify changes to BANKS_WITH_LIMITED_HISTORY

The AI summary mentions the removal of 'VUB_BANKA_SUBASKBX' and 'REVOLUT_REVOLT21' from BANKS_WITH_LIMITED_HISTORY, but these changes are not visible in the provided code.

Could you please clarify if these changes were intended and explain their relation to the Boursorama Bank integration? Let's verify the current state of BANKS_WITH_LIMITED_HISTORY:

#!/bin/bash
# Description: Verify the current state of BANKS_WITH_LIMITED_HISTORY

echo "Checking BANKS_WITH_LIMITED_HISTORY:"
rg "BANKS_WITH_LIMITED_HISTORY\s*=\s*\[" -A 50 src/app-gocardless/bank-factory.js

echo "Specifically checking for VUB_BANKA_SUBASKBX and REVOLUT_REVOLT21:"
rg "'VUB_BANKA_SUBASKBX'" src/app-gocardless/bank-factory.js
rg "'REVOLUT_REVOLT21'" src/app-gocardless/bank-factory.js

Please update the PR description to reflect these changes if they were intentional.

---

4-4: LGTM for Boursorama addition. Verify removed banks.

The addition of Boursorama bank integration aligns with the PR objectives. Good job on implementing this new integration.

However, the AI summary mentions the removal of BancsabadellBsabesbb and CBCcregbebb, which is not visible in the provided code. Let's verify these removals:

Please confirm if these banks were intentionally removed and update the PR description if necessary.

Also applies to: 34-34

Verification successful

---

Confirmed Removal of BancsabadellBsabesbb and CBCcregbebb

The removal of BancsabadellBsabesbb and CBCcregbebb from the bank-factory.js has been successfully verified. Both banks are no longer present in the BANKS_WITH_LIMITED_HISTORY or the banks array.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the removal of BancsabadellBsabesbb and CBCcregbebb

# Test 1: Check if BancsabadellBsabesbb is still present
echo "Checking for BancsabadellBsabesbb:"
rg "BancsabadellBsabesbb" src/app-gocardless/bank-factory.js

# Test 2: Check if CBCcregbebb is still present
echo "Checking for CBCcregbebb:"
rg "CBCcregbebb" src/app-gocardless/bank-factory.js

# Test 3: Verify these banks are not in the banks array
echo "Checking banks array:"
rg "banks\s*=\s*\[" -A 30 src/app-gocardless/bank-factory.js

Length of output: 2291

src/app-gocardless/banks/BOURSORAMA_BOUSFRPP.js (1)

13-60: LGTM! The normalizeTransaction function correctly cleans the transaction data

The implementation effectively removes unwanted keywords from the transaction details and assigns the payee names based on the transaction amount. This aligns with the PR objectives to improve data import accuracy for the Boursorama Bank integration.

[bakoff44]

@coderabbitai review

[coderabbitai]

Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[matt-fidd]

Thanks for this! Would it be possible for you to add some test cases for these changes in as well please?

[github-actions]

👋 Hi! It looks like this PR has not had any changes for a week now. Would you like someone to review this PR? If so - please remove the "[WIP]" prefix from the PR title. That will let the community know that this PR is open for a review.

[github-actions]

This PR was closed because it has been stalled for 5 days with no activity.