🐛 Extra error handling for if user has incorrect server url (#3736)

* adding some safety for if user has incorrect server url format

* added additional error handling for when incorrect server url has been setup

* good rabbit

packages/loot-core/src/server/server-config.ts

@@ -27,13 +27,22 @@ export function setServer(url: string): void {
 // `url` is optional; if not given it will provide the global config
 export function getServer(url?: string): ServerConfig | null {
   if (url) {
-    return {
-      BASE_SERVER: url,
-      SYNC_SERVER: joinURL(url, '/sync'),
-      SIGNUP_SERVER: joinURL(url, '/account'),
-      GOCARDLESS_SERVER: joinURL(url, '/gocardless'),
-      SIMPLEFIN_SERVER: joinURL(url, '/simplefin'),
-    };
+    try {
+      return {
+        BASE_SERVER: url,
+        SYNC_SERVER: joinURL(url, '/sync'),
+        SIGNUP_SERVER: joinURL(url, '/account'),
+        GOCARDLESS_SERVER: joinURL(url, '/gocardless'),
+        SIMPLEFIN_SERVER: joinURL(url, '/simplefin'),
+      };
+    } catch (error) {
+      console.warn(
+        'Unable to parse server URL - using the global config.',
+        { config },
+        error,
+      );
+      return config;
+    }
   }
   return config;
 }

upcoming-release-notes/3736.md

@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [MikesGlitch]
+---
+
+Add extra error handling for when an incorrect server URL has been setup