chore: add more concrete types to loot-core
#1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Marking draft as I rebased this onto master without noticing that it depends on types from #1077. |
* master: ⬆️ upgrade @reach/listbox and remove monkeypatch (actualbudget#1190) 🔥 remove beta code and some unused scripts (actualbudget#1189) Goals: Use shared 'months' functions for time (actualbudget#1082)
* master: Update .eslintignore (actualbudget#1218) Remove redundant UUID wrapper module, update uuid package to 9.x (actualbudget#1216) Fix size comparison workflow on fork PRs (actualbudget#1214) Move the rest of the syncing protobuf code to the CRDT package (actualbudget#1217) Bundle only the variable font version of Inter (actualbudget#1213) Improve some of the typings in loot-core (actualbudget#1180) Display bundle size changes in comments on opened PRs (actualbudget#1205) Consistently use ExternalLink (actualbudget#1184) Run ESLint at the top level once (actualbudget#1202) Add public/data to .eslintignore in desktop-client (actualbudget#1199) Remove unused deps from desktop-client (actualbudget#1200) Add release note ⬆️ upgrade hotkeys-js from v3.8.2 to v3.10.3, remove monkeypatch (actualbudget#1195) Fix navigating to the per-category per-month page (actualbudget#1182) ⬆️ upgrade react-dnd and remove monkeypatch (actualbudget#1192)
Bundle Stats - desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle Stats - loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
* master: (34 commits) chore: add types to `crdt` package (actualbudget#1076) Fix layout of the management app with the demo bar in place (actualbudget#1267) ♻️ (select) removing 2x usages of the Select component (actualbudget#1259) Fix transaction list scrolling behavior (actualbudget#1260) 🐛 fix link-schedule option in transaction table (actualbudget#1250) cleared/uncleared background update (actualbudget#1265) Fix calculation of how many table rows to render (actualbudget#1262) ♻️ moving more components out of common.tsx (actualbudget#1257) ♻️ moving some components from common.tsx to separate files (actualbudget#1248) 🐛 fix toggling of balances in all-accounts view (actualbudget#1252) 🐛 (mobile) reduce the size of account cards (actualbudget#1247) Fix electron export issue (actualbudget#1242) Saved Filters Page (actualbudget#1122) 🔧 cancel previous CI runs if a new push is made (actualbudget#1251) .gitattributes Check line endings for tsx files (actualbudget#1246) Fix importing transfers from YNAB4/5 (actualbudget#1224) Auto-close the local/nordigen picker modal after creating an account (actualbudget#1219) Run “Handle completed feature requests” in pull_request_target (actualbudget#1243) Add electron options to bug-report.yml (actualbudget#1239) Add onClick handlers to the schedule and transaction icons in the transaction list (actualbudget#1228) ...
j-f1
reviewed
Jul 4, 2023
|
👋 I'll close this off for now due to inactivity and the conflicts. But please feel free to re-open (or open a new PR) if you resume working on this. |
MatissJanis
approved these changes
Jul 29, 2023
trafico-bot
bot
added
✨ Merged
FlorianLang06
pushed a commit
to FlorianLang06/actual
that referenced
this pull request
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds explicit types to several directories in
loot-core. There's a slight conflict with #1180 inmonths.tswhich will need to be resolved.Waiting on #1077 to be merged.