-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move YNAB4/5 import code into loot-core #1208
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats - desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle Stats - loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller
Unchanged
|
I'm kinda torn on this one.. from one perspective: makes total sense to simplify this. From another: it's used by a few folks already. We might break their usage. https://www.npmjs.com/package/@actual-app/import-ynab4 Maybe not a biggie though.. I'd be really interested to hear @jlongster thoughts on this. |
That package hasn’t been updated since the open source changeover, fwiw |
} catch (e) { | ||
throw new Error('Error parsing Budget.yull file'); | ||
throw new Error('Error parsing Budget.yfull file'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this change intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, the file extension is yfull
full so this must have been a typo.
This cleans up the directory structure a bit and helps keep related functionality together. The code still uses
@actual-app/api
— I’m not sure if it would make sense to port to calling the underlying handlers directly?