Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move YNAB4/5 import code into loot-core #1208

Merged
merged 10 commits into from
Jul 30, 2023
Merged

Move YNAB4/5 import code into loot-core #1208

merged 10 commits into from
Jul 30, 2023

Conversation

j-f1
Copy link
Contributor

@j-f1 j-f1 commented Jun 27, 2023

This cleans up the directory structure a bit and helps keep related functionality together. The code still uses @actual-app/api — I’m not sure if it would make sense to port to calling the underlying handlers directly?

@trafico-bot trafico-bot bot added the 🚧 WIP label Jun 27, 2023
@netlify
Copy link

netlify bot commented Jun 27, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 0757ffc
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/64c5db654611fa0007a41539
😎 Deploy Preview https://deploy-preview-1208.demo.actualbudget.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@j-f1 j-f1 changed the title [WIP] Remove ynab4/5 importer packages and move the code into loot-core [WIP] Move YNAB4/5 import code into loot-core Jun 27, 2023
@j-f1 j-f1 changed the title [WIP] Move YNAB4/5 import code into loot-core Move YNAB4/5 import code into loot-core Jun 27, 2023
@j-f1 j-f1 marked this pull request as ready for review June 27, 2023 16:08
@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2023

Bundle Stats - desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 2.08 MB 0%
Changeset
File Δ Size
../loot-core/src/shared/util.ts 📈 +131 B (+2.01%) 6.35 KB -> 6.48 KB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/main.js 848.84 KB 0%
static/js/457.chunk.js 388.22 KB 0%
static/media/Inter-italic.var.woff2 239.29 KB 0%
static/media/Inter-roman.var.woff2 221.86 KB 0%
static/js/wide-components.chunk.js 159.3 KB 0%
static/js/383.chunk.js 117.35 KB 0%
static/js/reports.chunk.js 32.27 KB 0%
static/js/narrow-components.chunk.js 31.94 KB 0%
static/js/281.chunk.js 28.55 KB 0%
static/js/876.chunk.js 26.2 KB 0%
static/js/969.chunk.js 12.94 KB 0%
static/js/resize-observer-polyfill.chunk.js 8.12 KB 0%
static/css/main.css 5.82 KB 0%
asset-manifest.json 2.07 KB 0%
index.html 1.66 KB 0%
static/media/browser-server.js 963 B 0%

@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2023

Bundle Stats - loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 1.97 MB -> 1.97 MB (-300 B) -0.01%
Changeset
File Δ Size
packages/loot-core/src/server/importers/ynab4.ts 🆕 +10.51 KB 0 B -> 10.51 KB
packages/loot-core/src/server/importers/ynab5.ts 🆕 +8.17 KB 0 B -> 8.17 KB
packages/loot-core/src/server/importers/actual.ts 🆕 +1.34 KB 0 B -> 1.34 KB
packages/loot-core/src/server/importers/index.ts 🆕 +1.08 KB 0 B -> 1.08 KB
packages/loot-core/src/shared/util.ts 📈 +184 B (+2.30%) 7.81 KB -> 7.99 KB
packages/loot-core/src/server/cloud-storage.ts 📈 +13 B (+0.12%) 10.84 KB -> 10.86 KB
packages/loot-core/src/server/main.ts 📉 -2.14 KB (-3.54%) 60.42 KB -> 58.29 KB
packages/import-ynab4/importer.js 🔥 -11.65 KB (-100%) 11.65 KB -> 0 B
packages/import-ynab5/importer.js 🔥 -8.57 KB (-100%) 8.57 KB -> 0 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
kcab.worker.js 1011.11 KB -> 1010.82 KB (-300 B) -0.03%

Unchanged

Asset File Size % Changed
xfo.xfo.kcab.worker.js 1004.04 KB 0%

@MatissJanis
Copy link
Member

I'm kinda torn on this one.. from one perspective: makes total sense to simplify this.

From another: it's used by a few folks already. We might break their usage.

https://www.npmjs.com/package/@actual-app/import-ynab4

Maybe not a biggie though.. I'd be really interested to hear @jlongster thoughts on this.

@j-f1
Copy link
Contributor Author

j-f1 commented Jun 27, 2023

That package hasn’t been updated since the open source changeover, fwiw

@j-f1 j-f1 linked an issue Jun 28, 2023 that may be closed by this pull request
} catch (e) {
throw new Error('Error parsing Budget.yull file');
throw new Error('Error parsing Budget.yfull file');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this change intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, the file extension is yfull full so this must have been a typo.

@j-f1 j-f1 merged commit fd5ace5 into master Jul 30, 2023
15 checks passed
@j-f1 j-f1 deleted the jed/inline-import branch July 30, 2023 14:21
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Jul 30, 2023
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up importer packages
2 participants