Add typings to most of the Redux logic #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats - desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller
Unchanged
|
Bundle Stats - loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
j-f1
force-pushed
the
jed/type-state
branch
2 times, most recently
from
84bc933
to
5fc7323
Compare
j-f1
force-pushed
the
jed/type-state
branch
2 times, most recently
from
4f8f306
to
fe59e3a
Compare
|
Gonna reorg the commits here & open a second PR with just the modal types since they’re the most complex bit. |
MatissJanis
reviewed
Jul 18, 2023
| @@ -563,7 +562,7 @@ export async function createTestBudget(handlers) { | |||
| await db.runQuery('DELETE FROM categories;'); | |||
| await db.runQuery('DELETE FROM category_groups'); | |||
|
|
|||
| let accounts: AccountEntity[] = [ | |||
| let accounts: { name: string; offBudget?: 1; id?: string }[] = [ | |||
There was a problem hiding this comment.
❓ question: do we even need a type here? Isn't it already implied from the data struct we provide it?
There was a problem hiding this comment.
Yes, because otherwise the id property won’t be inferred
trafico-bot
bot
added
✨ Merged
FlorianLang06
pushed a commit
to FlorianLang06/actual
that referenced
this pull request
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will automatically flow types into
useSelectoranddispatchcalls. Action (heh) item: port components touseActions()to get access to typed actions.