Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatch the click event after adding the change listener #1345

Closed
wants to merge 3 commits into from

Conversation

j-f1
Copy link
Contributor

@j-f1 j-f1 commented Jul 15, 2023

Fixes #1313 (hopefully). My guess is that in Safari, the click event triggers a synchronous modal to open rather than an asynchronous one, so sometimes the change event is triggered before the handler can be registered?

@netlify
Copy link

netlify bot commented Jul 15, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit fd0fe5b
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/64b319d6d0e64d0008bb435e
😎 Deploy Preview https://deploy-preview-1345--actualbudget.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

Bundle Stats - desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
13 2.34 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/main.js 1.03 MB 0%
static/js/457.chunk.js 387.21 KB 0%
static/media/Inter.var.woff2 317.25 KB 0%
static/media/Inter-italic.var.woff2 239.29 KB 0%
static/media/Inter-roman.var.woff2 221.86 KB 0%
static/media/bg.svg 116.73 KB 0%
static/js/reports.chunk.js 20.77 KB 0%
static/js/969.chunk.js 12.94 KB 0%
static/js/resize-observer-polyfill.chunk.js 8.12 KB 0%
static/css/main.css 6.08 KB 0%
index.html 1.68 KB 0%
asset-manifest.json 1.47 KB 0%
static/media/browser-server.js 963 B 0%

@github-actions
Copy link
Contributor

Bundle Stats - loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 1.97 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1016.62 KB 0%
xfo.xfo.kcab.worker.js 1004.04 KB 0%

@Cldfire
Copy link
Contributor

Cldfire commented Jul 15, 2023

Tested the netlify demo in Safari 16.5.2 and unfortunately this does not fix the issue, uploading a .csv for import still does nothing.

@Cldfire
Copy link
Contributor

Cldfire commented Jul 15, 2023

I'll take a peek and see what I can figure out when I have the chance, I don't have time atm

@Cldfire
Copy link
Contributor

Cldfire commented Jul 16, 2023

See #1349, it should do the trick

@j-f1 j-f1 closed this Jul 16, 2023
@j-f1 j-f1 deleted the jed/file-upload branch July 16, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: File uploads in Safari don’t always do work the first time
2 participants