Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goals: Second speed improvement #1347

Closed
wants to merge 5 commits into from

Conversation

shall0pass
Copy link
Contributor

This reworks when the cells are filled. The function to fill the table will only happen at the end of each priority level which means I have to track the top 'To Budget' amount manually instead of doing table calls. This PR and uses a near identical function to the setZero and other functions in the actions file. This change allowed my 57 templates to be processed and filled in 850 ms, which is another 3-4x speed improvement. Overall, between both of these PRs the speed gain has been about 5x.

@netlify
Copy link

netlify bot commented Jul 15, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 7ababa5
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/64b6e06fde7cba0007feadf7
😎 Deploy Preview https://deploy-preview-1347.demo.actualbudget.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 15, 2023

Bundle Stats - desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
13 2.34 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/main.js 1.03 MB 0%
static/js/457.chunk.js 387.21 KB 0%
static/media/Inter.var.woff2 317.25 KB 0%
static/media/Inter-italic.var.woff2 239.29 KB 0%
static/media/Inter-roman.var.woff2 221.86 KB 0%
static/media/bg.svg 116.73 KB 0%
static/js/reports.chunk.js 20.8 KB 0%
static/js/969.chunk.js 12.94 KB 0%
static/js/resize-observer-polyfill.chunk.js 8.12 KB 0%
static/css/main.css 6.08 KB 0%
index.html 1.68 KB 0%
asset-manifest.json 1.47 KB 0%
static/media/browser-server.js 963 B 0%

@github-actions
Copy link
Contributor

github-actions bot commented Jul 15, 2023

Bundle Stats - loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 1.96 MB -> 1.96 MB (+161 B) +0.01%
Changeset
File Δ Size
packages/loot-core/src/server/budget/goaltemplates.ts 📈 +449 B (+2.16%) 20.34 KB -> 20.77 KB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
kcab.worker.js 1007.79 KB -> 1007.95 KB (+161 B) +0.02%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
xfo.xfo.kcab.worker.js 1004.04 KB 0%

@shall0pass shall0pass marked this pull request as draft July 15, 2023 23:33
@shall0pass shall0pass marked this pull request as ready for review July 16, 2023 00:10
@shall0pass shall0pass marked this pull request as draft July 18, 2023 20:06
@MatissJanis
Copy link
Member

👋 Would you mind solving the merge conflict? :)

@shall0pass
Copy link
Contributor Author

I have these changes in #1350 as well because I'm touching the same files. I'd prefer not to deal with any more self inflicted merge conflicts, if that's alright.

@shall0pass shall0pass closed this Jul 27, 2023
@shall0pass shall0pass deleted the goals_speed2 branch July 27, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants