-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Goals: Second speed improvement #1347
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats - desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle Stats - loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
👋 Would you mind solving the merge conflict? :) |
I have these changes in #1350 as well because I'm touching the same files. I'd prefer not to deal with any more self inflicted merge conflicts, if that's alright. |
This reworks when the cells are filled. The function to fill the table will only happen at the end of each priority level which means I have to track the top 'To Budget' amount manually instead of doing table calls. This PR and uses a near identical function to the setZero and other functions in the actions file. This change allowed my 57 templates to be processed and filled in 850 ms, which is another 3-4x speed improvement. Overall, between both of these PRs the speed gain has been about 5x.