Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Variable schedule preview times #1387

Closed
wants to merge 15 commits into from

Conversation

biohzrddd
Copy link
Contributor

@biohzrddd biohzrddd commented Jul 22, 2023

<CopyPasta from Discord discussion>

I'd like to see preview transactions out to the end of the month/week/for X days, etc. I found it was hard-coded to <= 7 days in the future, so made this. Same idea as #550, we want to see the budget out to some variable point in the future.

Normally the fake transaction row shows a summary of the preview
image

The settings row is visible on clicking the row (or pressing the edit button shown on hover), settings get changed which will show the new set of scheduled transactions, then hit Done when complete.
image

…preview"

This reverts commit dea3a66, reversing
changes made to 9d2804e.
@netlify
Copy link

netlify bot commented Jul 22, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 8a71b1a
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/64c6414b5aa0da000875757a
😎 Deploy Preview https://deploy-preview-1387.demo.actualbudget.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@biohzrddd biohzrddd marked this pull request as draft July 22, 2023 22:45
@biohzrddd biohzrddd changed the title Revert "Merge remote-tracking branch 'upstream/master' into variable-… [WIP] Variable schedule preview times Jul 22, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2023

Bundle Stats - desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 2.08 MB -> 2.08 MB (+2.36 KB) +0.11%
Changeset
File Δ Size
src/components/schedules/TransactionPreviewPicker.tsx 🆕 +4.06 KB 0 B -> 4.06 KB
src/components/settings/Experimental.tsx 📈 +404 B (+15.29%) 2.58 KB -> 2.97 KB
src/hooks/useFeatureFlag.ts 📈 +25 B (+7.29%) 343 B -> 368 B
src/components/accounts/Account.js 📈 +183 B (+0.59%) 30.29 KB -> 30.47 KB
src/components/transactions/TransactionsTable.js 📉 -115 B (-0.29%) 38.9 KB -> 38.79 KB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/wide-components.chunk.js 159.3 KB -> 161.37 KB (+2.07 KB) +1.30%
static/js/main.js 848.84 KB -> 849.12 KB (+292 B) +0.03%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/457.chunk.js 388.22 KB 0%
static/media/Inter-italic.var.woff2 239.29 KB 0%
static/media/Inter-roman.var.woff2 221.86 KB 0%
static/js/383.chunk.js 117.35 KB 0%
static/js/reports.chunk.js 32.27 KB 0%
static/js/narrow-components.chunk.js 31.94 KB 0%
static/js/281.chunk.js 28.55 KB 0%
static/js/876.chunk.js 26.2 KB 0%
static/js/969.chunk.js 12.94 KB 0%
static/js/resize-observer-polyfill.chunk.js 8.12 KB 0%
static/css/main.css 5.82 KB 0%
asset-manifest.json 2.07 KB 0%
index.html 1.66 KB 0%
static/media/browser-server.js 963 B 0%

@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2023

Bundle Stats - loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 1.97 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1011.09 KB 0%
xfo.xfo.kcab.worker.js 1004.04 KB 0%

@biohzrddd
Copy link
Contributor Author

I'm trying to get the preference setting setup but don't understand react redux enough. I'm guessing something with dispatch but not sure what and the react redux docs are VERY sparse.

Specifically TransactionPreviewPicker.tsx line 114

@j-f1
Copy link
Contributor

j-f1 commented Jul 29, 2023

If you call useActions(), you’ll get back an object of all the different redux actions. In this case you’ll want the savePrefs action for local (per-file) prefs, or saveGlobalPrefs for global prefs. Example:

let { savePrefs } = useActions();

// ...

savePrefs({ myPref: "newValue" });

@github-actions
Copy link
Contributor

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Aug 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

This PR was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants