-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Goals: add flag to percent goals to use previous month income instead of this months #1403
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats - desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle Stats - loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It behaves exactly as described :)
One thought. Should we use 'previous' instead of 'prev'? The other templates use full words in the syntax that resembles a sentence. |
probably. Ill do that |
Edit: copy/paste got me :) |
I left the available funds unchanged. So yes, having the flag there does nothing different It made it easier on the parsing side to allow the flag there. |
👍 |
@shall0pass feel free to merge if you’re happy with the PR! |
Matches [#1403](actualbudget/actual#1403) Tweaked some things that I noticed that were confusing. --------- Co-authored-by: shall0pass <[email protected]>
… of this months (actualbudget#1403) This is a more elegant way of implementing a month ahead version of the percent goals. To use it add the `previous` flag to the percent goal, ex `#template 10% of previous Paycheck`.
This is a more elegant way of implementing a month ahead version of the percent goals. To use it add the
previous
flag to the percent goal, ex#template 10% of previous Paycheck
.