Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goals: add flag to percent goals to use previous month income instead of this months #1403

Merged
merged 9 commits into from
Jul 29, 2023
Merged

Goals: add flag to percent goals to use previous month income instead of this months #1403

merged 9 commits into from
Jul 29, 2023

Conversation

youngcw
Copy link
Member

@youngcw youngcw commented Jul 27, 2023

This is a more elegant way of implementing a month ahead version of the percent goals. To use it add the previous flag to the percent goal, ex #template 10% of previous Paycheck.

@netlify
Copy link

netlify bot commented Jul 27, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit a9da516
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/64c42f7dfbd1bd00089d5b7c
😎 Deploy Preview https://deploy-preview-1403.demo.actualbudget.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2023

Bundle Stats - desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 2.08 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/main.js 848.52 KB 0%
static/js/457.chunk.js 388.22 KB 0%
static/media/Inter-italic.var.woff2 239.29 KB 0%
static/media/Inter-roman.var.woff2 221.86 KB 0%
static/js/wide-components.chunk.js 159.28 KB 0%
static/js/383.chunk.js 117.35 KB 0%
static/js/reports.chunk.js 32.25 KB 0%
static/js/narrow-components.chunk.js 31.94 KB 0%
static/js/281.chunk.js 28.55 KB 0%
static/js/876.chunk.js 26.2 KB 0%
static/js/969.chunk.js 12.94 KB 0%
static/js/resize-observer-polyfill.chunk.js 8.12 KB 0%
static/css/main.css 5.82 KB 0%
asset-manifest.json 2.07 KB 0%
index.html 1.66 KB 0%
static/media/browser-server.js 963 B 0%

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2023

Bundle Stats - loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 1.97 MB -> 1.97 MB (+533 B) +0.03%
Changeset
File Δ Size
packages/loot-core/src/server/budget/goal-template.pegjs 📈 +1.82 KB (+4.00%) 45.53 KB -> 47.35 KB
packages/loot-core/src/server/budget/goaltemplates.ts 📈 +542 B (+2.36%) 22.4 KB -> 22.93 KB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
kcab.worker.js 1010.37 KB -> 1010.89 KB (+533 B) +0.05%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
xfo.xfo.kcab.worker.js 1004.04 KB 0%

Copy link
Contributor

@shall0pass shall0pass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It behaves exactly as described :)

@shall0pass
Copy link
Contributor

One thought. Should we use 'previous' instead of 'prev'? The other templates use full words in the syntax that resembles a sentence.

@youngcw
Copy link
Member Author

youngcw commented Jul 28, 2023

Should we use 'previous' instead of 'prev'? The other templates use full words in the syntax that resembles a sentence.

probably. Ill do that

@shall0pass
Copy link
Contributor

shall0pass commented Jul 28, 2023

#template 10% of previous available funds returns the same value as #template 10% of available funds. I don't think it should have returned anything, right?

Edit: copy/paste got me :)

@youngcw
Copy link
Member Author

youngcw commented Jul 28, 2023

I left the available funds unchanged. So yes, having the flag there does nothing different

It made it easier on the parsing side to allow the flag there.

@shall0pass
Copy link
Contributor

👍

@shall0pass shall0pass requested review from shall0pass and removed request for shall0pass July 28, 2023 22:18
@j-f1
Copy link
Contributor

j-f1 commented Jul 29, 2023

@shall0pass feel free to merge if you’re happy with the PR!

@shall0pass shall0pass merged commit 9273a0a into actualbudget:master Jul 29, 2023
15 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Jul 29, 2023
shall0pass added a commit to actualbudget/docs that referenced this pull request Jul 29, 2023
Matches [#1403](actualbudget/actual#1403)

Tweaked some things that I noticed that were confusing.

---------

Co-authored-by: shall0pass <[email protected]>
@youngcw youngcw deleted the goals_percentagePrev branch July 31, 2023 16:34
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
… of this months (actualbudget#1403)

This is a more elegant way of implementing a month ahead version of the
percent goals. To use it add the `previous` flag to the percent goal, ex
`#template 10% of previous Paycheck`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants