Fix Sorting/Balance interactions

[carkom]

There were lines from #1232 that were left out of #1354. They are still missing from the current master file. This adds them back in to restore the functionality of 1232.

[netlify]

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	1174bbf
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/64c3ad5174f3dc00088e19d6
😎 Deploy Preview	https://deploy-preview-1406.demo.actualbudget.org/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

Bundle Stats - desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
16	2.08 MB -> 2.08 MB (+121 B)	+0.01%

Changeset

File	Δ	Size
src/components/accounts/Account.js	📈 +120 B (+0.39%)	30.17 KB -> 30.29 KB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
static/js/wide-components.chunk.js	159.09 KB -> 159.21 KB (+121 B)	+0.07%

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/main.js	856 KB	0%
static/js/457.chunk.js	388.22 KB	0%
static/media/Inter-italic.var.woff2	239.29 KB	0%
static/media/Inter-roman.var.woff2	221.86 KB	0%
static/js/383.chunk.js	117.35 KB	0%
static/js/reports.chunk.js	32.38 KB	0%
static/js/narrow-components.chunk.js	32.17 KB	0%
static/js/281.chunk.js	28.55 KB	0%
static/js/876.chunk.js	26.2 KB	0%
static/js/969.chunk.js	12.94 KB	0%
static/js/resize-observer-polyfill.chunk.js	8.12 KB	0%
static/css/main.css	5.82 KB	0%
asset-manifest.json	2.07 KB	0%
index.html	1.66 KB	0%
static/media/browser-server.js	963 B	0%

[github-actions]

Bundle Stats - loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
2	1.97 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1010.37 KB	0%
xfo.xfo.kcab.worker.js	1004.04 KB	0%

[carkom]

I'm finding that PR #1354 creates a really confusing user experience with sorting and balances.

With balance shown, sorting by any colomn does not hide the balance column but rather just blanks out all rows. Then the menu drop down doesn't show anything about hiding the balance column until you clear all sorting.

[carkom]

With balance shown, sorting by any colomn does not hide the balance column but rather just blanks out all rows. Then the menu drop down doesn't show anything about hiding the balance column until you clear all sorting.

Fixed this by adjusting the "showBalance" element that is being passed to the transactionsList/Table. Other option is way more comlex and involves changing showBalance state with each interaction of the page.

[carkom]

I've adjusted the transactionList Headers so they line up again.

@j-f1 can you check that I haven't re-created this issue (#1380) with my change?

[carkom]

@joel-jeremy can you make sure my changes haven't broken anything with your previous PR's (#1354) functionality? I want to make sure they are all palying together nicely. 😁

[j-f1]

can you check that I haven't re-created this issue (#1380) with my change?

Looks to still be ok in the deploy preview!

[joel-jeremy]

can you make sure my changes haven't broken anything with your previous PR's (#1354) functionality

Looks like it still works. Thank you for the fix!

[carkom]

Thanks all!

@j-f1 ready for review.

[j-f1]

Thanks!