Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 (electron) always show titlebar #1417

Merged
merged 2 commits into from
Jul 29, 2023
Merged

Conversation

MatissJanis
Copy link
Member

#1047

Before:

image

After:

Screenshot 2023-07-29 at 20 12 25

@netlify
Copy link

netlify bot commented Jul 29, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit aee7bd7
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/64c5652ac9df2f0008ad2cc1
😎 Deploy Preview https://deploy-preview-1417.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MatissJanis
Copy link
Member Author

Would appreciate some testing on windows machine here @Shazib

@github-actions
Copy link
Contributor

Bundle Stats - desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 2.08 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/main.js 848.84 KB 0%
static/js/457.chunk.js 388.22 KB 0%
static/media/Inter-italic.var.woff2 239.29 KB 0%
static/media/Inter-roman.var.woff2 221.86 KB 0%
static/js/wide-components.chunk.js 159.3 KB 0%
static/js/383.chunk.js 117.35 KB 0%
static/js/reports.chunk.js 32.27 KB 0%
static/js/narrow-components.chunk.js 31.94 KB 0%
static/js/281.chunk.js 28.55 KB 0%
static/js/876.chunk.js 26.2 KB 0%
static/js/969.chunk.js 12.94 KB 0%
static/js/resize-observer-polyfill.chunk.js 8.12 KB 0%
static/css/main.css 5.82 KB 0%
asset-manifest.json 2.07 KB 0%
index.html 1.66 KB 0%
static/media/browser-server.js 963 B 0%

@github-actions
Copy link
Contributor

Bundle Stats - loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 1.97 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1011.09 KB 0%
xfo.xfo.kcab.worker.js 1004.04 KB 0%

@Shazib
Copy link
Contributor

Shazib commented Jul 29, 2023

Would appreciate some testing on windows machine here @Shazib

Looks good to me.

The '<<' to collapse is broken and practically invisible but thats probably an unrelated dark-theme thing.

image

Copy link
Contributor

@j-f1 j-f1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works! A little less fancy than the old style but a lot easier to deal with conceptually.

@MatissJanis
Copy link
Member Author

@Shazib thanks, we have already an issue for that here: #1416 :)

@MatissJanis MatissJanis merged commit 61d7074 into master Jul 29, 2023
15 checks passed
@MatissJanis MatissJanis deleted the matiss/electron-titlebar branch July 29, 2023 20:19
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Jul 29, 2023
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants