♻️ (common) migrating to specific common component import paths pt2 #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats - desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller
Unchanged
|
Bundle Stats - loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
j-f1
reviewed
Jul 30, 2023
Comment on lines
14
to
15
| export { default as Text } from './common/Text'; | ||
| export { default as View } from './common/View'; |
There was a problem hiding this comment.
Do you want to remove these too?
There was a problem hiding this comment.
Yea. In pt3 those will go too. Didn't want to do one massive migration, so doing this slowly over multiple PRs.
There was a problem hiding this comment.
Makes sense, it was a bit surprising that there were only 40 files using Text/View. Guess that’s because there are way more!
j-f1
reviewed
Jul 30, 2023
Co-authored-by: Jed Fox <[email protected]>
j-f1
approved these changes
Jul 30, 2023
trafico-bot
bot
added
✨ Merged
FlorianLang06
pushed a commit
to FlorianLang06/actual
that referenced
this pull request
Mar 7, 2024
…ctualbudget#1419) Part 2 of the path migration. No functional changes. Part 1: actualbudget#1418 --------- Co-authored-by: Jed Fox <[email protected]>
FlorianLang06
pushed a commit
to FlorianLang06/actual
that referenced
this pull request
Mar 7, 2024
…ctualbudget#1420) Part 3 of the migration. Part 2 here: actualbudget#1419
my2
added a commit
to my2/actual
that referenced
this pull request
Aug 13, 2024
…#1420) Part 3 of the migration. Part 2 here: actualbudget/actual#1419
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of the path migration. No functional changes.
Part 1: #1418