Goals: Schedule multi month forecasting #1452
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
|
I've done some testing of this now and it seems to work exactly like I expected it to work! :) |
|
Using the full flag seems broken. It will work well when the previous months have fully allocated funds, but if the category is at 0 then it will act like its a regular schedule. |
Thanks for checking. I'll try to fix that up. |
|
something broke with my priority test. It ends up getting negative values if the available funds are negative at time of priority pass (I think) |
I think I have it resolved. Could you run your test again? Thanks! |
|
Its a little better. It works well if started in the right month, but still budgets the whole thing in wrong months when the balance is 0 when applying the template. Also still getting the negative value in the priority test. |
|
Haven't done an in depth review of the code yet but the current implementation for schedule templates allocate a budget even though the schedule is already completed. Is it still the same here? I think we change that and just ignore the template if it's schedule is already completed. Thoughts? |
|
Currently it's the same. I'll look at doing a check for a completed schedule though, that's a great point. I'm still checking for bugs. I found a few more tonight that I hope I resolved with the latest commit, but I don't think I've addressed @youngcw comment about the negative value in a priority level. I'm still trying to replicate the conditions for that to occur so I can fix it. |
trafico-bot
bot
added
⚠️ Changes requested
|
I've also noticed that I'm not getting error or warning pop ups. The errors still seem to be passed back to the calling function correctly. Was there a change in the notification system that we need to address from this file? |
|
Priority thing is fixed. With the full flag it seems to be that after 3 broken months future months fill right. I can shift which month I start and it looks to be the same, 3 broken then good. Maybe that's just an artifact of my test. |
|
I think I broke the error notifications when doing the speed up improvements. The functions are async and those are the only functions not passing the Notifications back. The Check templates and End of month cleanup notifications still come up. I've been trying things, but I'm poking at something I don't fully understand. Could use a hint. 🙏 |
|
Beautiful. All my tests are working now. I can't tell what happened to the regular messages, but the messages for the template check still work. |
|
@youngcw would you mind doing a code review here? I could do it myself, but since I don't really use the feature.. it would be mostly a rubber stamp. |
|
Looks good! Tested and it no longer applies completed schedules. Thanks! |
trafico-bot
bot
added
✨ Merged
* master: (34 commits) ♻️ (crdt) adding more strict typings (actualbudget#1461) Goals: Schedule multi month forecasting (actualbudget#1452) Fix titlebar transparent background (actualbudget#1460) 🐛 (import) fix YNAB (and other) importers (actualbudget#1462) Fix the mobile footer color (actualbudget#1456) 🐛 (schedules) fix creating schedules with the same name (actualbudget#1463) Move big input component into Input.js, port some of the manager app to TS (actualbudget#1431) Bugfix: remove select component inner scrollbar (actualbudget#1458) ⬆️ (crdt) upgrade murmurhash (actualbudget#1438) ♻️ (crdt) adding more strict typings (actualbudget#1437) Add options on Import transactions screen to mark transactions as cleared/uncleared (actualbudget#1451) Reports privacy filter (actualbudget#1447) Sentence case in menus (actualbudget#1446) Goals: Allow up to to consider spent values (actualbudget#1448) Release note README link update (actualbudget#1449) fix eye coloring (actualbudget#1450) 🔖 (23.8.0) stability improvements and new experimental features (actualbudget#1444) Update to the latest version of the size compare action (actualbudget#1435) 🔥 remove unused budgetMonth (actualbudget#1432) 🐛 fix incorrect state slice usage (actualbudget#1433) ...
References discord discussion starting here: https://discord.com/channels/937901803608096828/940290142579605514/1133523705063030824 Currently the schedule keyword won't fill any future budget cells if the category balance already satisfies the schedule. This PR is an attempt to improve the behavior by allowing budget fills regardless of the category balance. This is a drastic rewrite of the schedule keyword. Though I've tried not to have any regressions, it is possible because of how different the logic is. I've tested compounding using a simple template, so a small change in the 'by' keyword was also made.
References discord discussion starting here: https://discord.com/channels/937901803608096828/940290142579605514/1133523705063030824
Currently the schedule keyword won't fill any future budget cells if the category balance already satisfies the schedule. This PR is an attempt to improve the behavior by allowing budget fills regardless of the category balance.
This is a drastic rewrite of the schedule keyword. Though I've tried not to have any regressions, it is possible because of how different the logic is. I've tested compounding using a simple template, so a small change in the 'by' keyword was also made.