Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 (schedules) fix showing balance of approximate transactions #1473

Merged
merged 4 commits into from
Aug 6, 2023

Conversation

MatissJanis
Copy link
Member

@MatissJanis MatissJanis commented Aug 6, 2023

Closes #1328

Closes #1471

@MatissJanis MatissJanis added this to the v23.8.1 milestone Aug 6, 2023
@netlify
Copy link

netlify bot commented Aug 6, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit b08b26c
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/64cfc14e87807900085bf085
😎 Deploy Preview https://deploy-preview-1473.demo.actualbudget.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 2.08 MB → 2.08 MB (+121 B) +0.01%
Changeset
File Δ Size
src/components/accounts/Balance.js 📈 +322 B (+8.66%) 3.63 kB → 3.94 kB
src/components/accounts/Account.js 📈 +83 B (+0.27%) 30.35 kB → 30.43 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/wide-components.chunk.js 159.17 kB → 159.29 kB (+121 B) +0.07%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/main.js 851.69 kB 0%
static/js/457.chunk.js 388.22 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/383.chunk.js 117.35 kB 0%
static/js/reports.chunk.js 33.23 kB 0%
static/js/narrow-components.chunk.js 32.06 kB 0%
static/js/281.chunk.js 28.55 kB 0%
static/js/876.chunk.js 26.2 kB 0%
static/js/969.chunk.js 12.94 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.12 kB 0%
static/css/main.css 5.82 kB 0%
asset-manifest.json 2.07 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 963 B 0%

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 1.97 MB → 1.97 MB (-496 B) -0.02%
Changeset
File Δ Size
packages/loot-core/src/server/accounts/sync.ts 📉 -912 B (-3.29%) 27.11 kB → 26.22 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
kcab.worker.js 1012.46 kB → 1011.97 kB (-496 B) -0.05%

Unchanged

Asset File Size % Changed
xfo.xfo.kcab.worker.js 1004.04 kB 0%

Copy link
Contributor

@shall0pass shall0pass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MatissJanis MatissJanis merged commit e78430d into master Aug 6, 2023
15 checks passed
@MatissJanis MatissJanis deleted the matiss/schedule-aprox branch August 6, 2023 18:30
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
2 participants