Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transactions button background color #1494

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

Cldfire
Copy link
Contributor

@Cldfire Cldfire commented Aug 8, 2023

It seems #1436 caused a regression in the background color of the transactions button.

demo.actualbudget.org right now looks like:

Screenshot 2023-08-08 at 7 12 24 PM

With the fix in this PR:

Screenshot 2023-08-08 at 7 12 50 PM

It looks like the transparent background was added explicitly in #1436: https://github.com/actualbudget/actual/pull/1436/files#diff-816cd66052d6811e3d3cac9f19920d8b57c09d3c3b0c882c4fc768d314776d45R905

It's not entirely clear to me why that was done, @carkom was there a specific reason for that change?

@netlify
Copy link

netlify bot commented Aug 8, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 0ed27c8
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/64d2cce5417e410007e34419
😎 Deploy Preview https://deploy-preview-1494.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
14 2.12 MB → 2.12 MB (+6 B) +0.00%
Changeset
File Δ Size
src/components/table.tsx 📈 +7 B (+0.03%) 23.14 kB → 23.15 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/main.js 944.09 kB → 944.1 kB (+6 B) +0.00%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/171.chunk.js 396.24 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/wide-components.chunk.js 156.68 kB 0%
static/js/383.chunk.js 117.35 kB 0%
static/js/reports.chunk.js 40.96 kB 0%
static/js/narrow-components.chunk.js 24.62 kB 0%
static/js/969.chunk.js 12.94 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.12 kB 0%
static/css/main.css 5.82 kB 0%
asset-manifest.json 1.78 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 963 B 0%

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 1.97 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1012.13 kB 0%
xfo.xfo.kcab.worker.js 1004.04 kB 0%

Copy link
Contributor

@trevdor trevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on light and dark mode. Thanks!

@trevdor trevdor merged commit b2738db into actualbudget:master Aug 9, 2023
15 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Aug 9, 2023
@Cldfire Cldfire deleted the jarek/fix-transactions-button branch August 9, 2023 03:03
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants