Port App and FatalError components to TS and functional components #1535
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
joel-jeremy
changed the title
joel-jeremy
force-pushed
the
functional-app-tsx
branch
from
fde515d
to
88ffaaa
Compare
joel-jeremy
changed the title
| window.addEventListener('focus', checkScrollbars); | ||
| } | ||
|
|
||
| initAll().catch(e => console.error(e)); |
There was a problem hiding this comment.
❓ question: won't this cause issues?
Before: if initialisation fails (for whatever reason) the exception gets thrown and it bubbles up. Eventually breaking the entire app (and thus fatal error message is shown).
Now: if initialisation fails - the exception is shallowed. Do we show an error?
There was a problem hiding this comment.
Updated to show error UI on init error
| setInitializing(false); | ||
| return; |
There was a problem hiding this comment.
💬 suggestion: I think we should throw an exception here.
Before: fatalError gets set and we show error message
Now: fatalError is not set - do we show an error? Don't think we do.
There was a problem hiding this comment.
Updated to show the error UI on init error
trafico-bot
bot
added
⚠️ Changes requested
trafico-bot
bot
added
🔍 Ready for Review
and removed
⚠️ Changes requested
|
The footer in mobile view should now be fixed. |
trafico-bot
bot
added
✨ Merged
…ctualbudget#1535) * Port app to functional component and tsx * FatalError functional component + tsx * Release notes * Exports cleanup * App cleanup * Address PR comments
Related to #1483