[Maintenance] Update CloseAccount, AccountAutocomplete, SavedFilterAutocomplete, PayeeAutocomplete components to Typescript. #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
MikesGlitch
commented
Nov 17, 2023
| @@ -95,7 +115,6 @@ function CloseAccount({ | |||
| <AccountAutocomplete | |||
| includeClosedAccounts={false} | |||
| value={transfer} | |||
| accounts={accounts} | |||
MikesGlitch
changed the title
MatissJanis
reviewed
Nov 18, 2023
| return <MultiAutocomplete {...props} />; | ||
| return ( | ||
| <MultiAutocomplete | ||
| {...(props as ComponentProps<typeof MultiAutocomplete>)} |
There was a problem hiding this comment.
💬 suggestion: you could create a tiny typeguard util function. That would help get rid of this manual type coercion.
There was a problem hiding this comment.
Added two typeguards and removed the "as" cast
MatissJanis
approved these changes
Nov 18, 2023
trafico-bot
bot
added
✨ Merged
FlorianLang06
pushed a commit
to FlorianLang06/actual
that referenced
this pull request
Mar 7, 2024
…tocomplete, PayeeAutocomplete components to Typescript. (actualbudget#1923)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert CloseAccount, AccountAutocomplete, SavedFilterAutocomplete, PayeeAutocomplete components to Typescript.
#1483