Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:electron: Convert window-state.js ➡️ window-state.ts #3027

Merged
merged 7 commits into from
Jul 13, 2024

Conversation

MikesGlitch
Copy link
Contributor

@MikesGlitch MikesGlitch commented Jul 10, 2024

#1483

  • Updated Electron window-state file to use typescript
  • Fixed a bug where the screen x/y values weren't being saved when the window was maximised
    • Caused the app to launch to the wrong display because it didn't know what display it belonged to

Tested on:

  • Windows
  • LInux

Copy link

netlify bot commented Jul 10, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 62b569d
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/668fa1bb7efbf900088705b6
😎 Deploy Preview https://deploy-preview-3027.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jul 10, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.95 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/usePreviewTransactions.js 790 B 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 76.15 kB 0%
static/js/AppliedFilters.js 27.5 kB 0%
static/js/wide.js 272.26 kB 0%
static/js/ReportRouter.js 1.23 MB 0%
static/js/index.js 3.2 MB 0%

Copy link
Contributor

github-actions bot commented Jul 10, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.13 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.13 MB 0%

@MikesGlitch MikesGlitch changed the title [WIP ]:electron: Convert window-state.js ➡️ window-state.ts [WIP ] :electron: Convert window-state.js ➡️ window-state.ts Jul 11, 2024
@MikesGlitch MikesGlitch marked this pull request as ready for review July 11, 2024 09:17
@MikesGlitch MikesGlitch changed the title [WIP ] :electron: Convert window-state.js ➡️ window-state.ts :electron: Convert window-state.js ➡️ window-state.ts Jul 11, 2024
Copy link
Member

@MatissJanis MatissJanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mac works as expected 👍

@MatissJanis MatissJanis merged commit b85f910 into actualbudget:master Jul 13, 2024
24 checks passed
@MikesGlitch MikesGlitch deleted the ts/window-state-electron branch July 13, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants