Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pay Distribution Template - PR Replacement for #3078 #3176

Closed

Conversation

Midgetwombat
Copy link

@Midgetwombat Midgetwombat commented Aug 2, 2024

New Pay Distribution template to add to goal templates. This PR is replacing PR #3078 Since it had too many git issues from inexperience. Please read the notes on that PR, also wrote documentation that may explain the workings better here Pay Distribution Documentation PR

ABOUT:
Added a new Template type called Pay Distribution, which is designed to be triggered every time the apply template is clicked. if a Pay Distribution template is applied to a category then instead of adding to the goal the distribution template will just add its value to the currently budgeted amount. if a normal template is applied to the category as well, then that template will add to the goal but will not change the value of the budgeted column.

The purpose of this new template is for people who budget by paycheck which may not be monthly, or for those who are still working on building up their funds to have enough to budget for a month.

The pay Distribution Template has two operations either a set amount OR a percentage of the remaining available funds.
Additionally, if the pay distribution template is added to the same category as the remainder template, then the remaining budget will be added to that category also. Otherwise, the remainder template will retain its normal functionality.

This is to replace the other branch, as that one had too many git errors.
@actual-github-bot actual-github-bot bot changed the title Pay Distribution Template - PR Replacemet for #3078 [WIP] Pay Distribution Template - PR Replacemet for #3078 Aug 2, 2024
Copy link

netlify bot commented Aug 2, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit d08501a
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/66b1848f501d6800084f9669
😎 Deploy Preview https://deploy-preview-3176.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Aug 2, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.81 MB → 4.8 MB (-3.87 kB) -0.08%
Changeset
File Δ Size
src/components/reports/spreadsheets/makeQuery.ts 📈 +198 B (+11.02%) 1.75 kB → 1.95 kB
src/hooks/useFilters.ts 📈 +115 B (+7.60%) 1.48 kB → 1.59 kB
src/components/filters/ConditionsOpMenu.tsx 📈 +46 B (+7.00%) 657 B → 703 B
src/components/reports/spreadsheets/grouped-spreadsheet.ts 📈 +229 B (+5.13%) 4.36 kB → 4.58 kB
home/runner/work/actual/actual/packages/loot-core/src/client/data-hooks/reports.ts 📈 +51 B (+4.29%) 1.16 kB → 1.21 kB
src/components/reports/spreadsheets/custom-spreadsheet.ts 📈 +229 B (+4.26%) 5.25 kB → 5.48 kB
src/components/reports/reports/GetCardData.tsx 📈 +144 B (+3.44%) 4.09 kB → 4.23 kB
src/components/reports/reports/SpendingCard.tsx 📈 +72 B (+1.87%) 3.76 kB → 3.83 kB
src/components/reports/spreadsheets/spending-spreadsheet.ts 📈 +46 B (+0.90%) 4.99 kB → 5.04 kB
home/runner/work/actual/actual/packages/loot-core/src/shared/util.ts 📈 +17 B (+0.26%) 6.38 kB → 6.4 kB
src/components/reports/graphs/SpendingGraph.tsx 📈 +2 B (+0.02%) 8.31 kB → 8.31 kB
src/components/table.tsx 📉 -23 B (-0.09%) 24.28 kB → 24.25 kB
src/components/reports/ReportOptions.ts 📉 -9 B (-0.13%) 6.63 kB → 6.62 kB
src/components/settings/Experimental.tsx 📉 -7 B (-0.22%) 3.08 kB → 3.08 kB
src/components/mobile/accounts/AccountTransactions.jsx 📉 -25 B (-0.39%) 6.3 kB → 6.28 kB
src/components/mobile/accounts/Accounts.jsx 📉 -33 B (-0.42%) 7.63 kB → 7.59 kB
src/components/common/Modal2.tsx 📉 -78 B (-0.82%) 9.26 kB → 9.18 kB
src/components/modals/TransferModal.tsx 📉 -35 B (-0.91%) 3.76 kB → 3.72 kB
src/components/reports/ReportSidebar.tsx 📉 -217 B (-1.20%) 17.67 kB → 17.46 kB
src/components/modals/CoverModal.tsx 📉 -35 B (-1.23%) 2.77 kB → 2.74 kB
src/components/reports/reports/Spending.tsx 📉 -222 B (-1.47%) 14.73 kB → 14.52 kB
src/components/budget/rollover/TransferMenu.tsx 📉 -44 B (-1.78%) 2.42 kB → 2.38 kB
home/runner/work/actual/actual/packages/loot-core/src/client/queries.ts 📉 -126 B (-1.81%) 6.8 kB → 6.68 kB
src/components/common/InputWithContent.tsx 📉 -25 B (-2.18%) 1.12 kB → 1.1 kB
src/components/budget/rollover/CoverMenu.tsx 📉 -40 B (-2.31%) 1.69 kB → 1.65 kB
home/runner/work/actual/actual/packages/loot-core/src/shared/rules.ts 📉 -171 B (-2.77%) 6.03 kB → 5.87 kB
src/components/transactions/TransactionsTable.jsx 📉 -2.2 kB (-3.50%) 62.93 kB → 60.73 kB
src/components/reports/reports/CustomReport.tsx 📉 -1.66 kB (-7.73%) 21.5 kB → 19.83 kB
src/components/spreadsheet/index.ts 🔥 -68 B (-100%) 68 B → 0 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/AppliedFilters.js 27.56 kB → 27.61 kB (+46 B) +0.16%

Smaller

Asset File Size % Changed
static/js/wide.js 279.55 kB → 277.26 kB (-2.29 kB) -0.82%
static/js/ReportRouter.js 1.24 MB → 1.23 MB (-1.09 kB) -0.09%
static/js/index.js 3.04 MB → 3.04 MB (-500 B) -0.02%
static/js/narrow.js 78.33 kB → 78.27 kB (-58 B) -0.07%

Unchanged

Asset File Size % Changed
static/js/resize-observer.js 18.37 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/usePreviewTransactions.js 790 B 0%

Copy link
Contributor

github-actions bot commented Aug 2, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.14 MB → 1.14 MB (+821 B) +0.07%
Changeset
File Δ Size
packages/loot-core/src/server/budget/goals/payDistribution.ts 🆕 +1.03 kB 0 B → 1.03 kB
packages/loot-core/src/server/budget/goaltemplates.ts 📈 +3.22 kB (+13.82%) 23.29 kB → 26.51 kB
packages/loot-core/src/server/budget/goals/goalsRemainder.ts 📈 +210 B (+13.78%) 1.49 kB → 1.69 kB
packages/loot-core/src/server/budget/goal-template.pegjs 📈 +6.44 kB (+11.83%) 54.47 kB → 60.91 kB
packages/loot-core/src/server/reports/app.ts 📈 +117 B (+2.71%) 4.22 kB → 4.34 kB
packages/loot-core/src/server/aql/schema/index.ts 📈 +40 B (+0.28%) 14.1 kB → 14.13 kB
packages/loot-core/src/server/accounts/parse-file.ts 📈 +8 B (+0.19%) 4.07 kB → 4.08 kB
packages/loot-core/src/shared/util.ts 📈 +17 B (+0.16%) 10.32 kB → 10.33 kB
packages/loot-core/src/server/filters/app.ts 📉 -12 B (-0.25%) 4.76 kB → 4.75 kB
packages/loot-core/src/mocks/budget.ts 📉 -337 B (-1.15%) 28.71 kB → 28.38 kB
packages/api/methods.ts 📉 -278 B (-1.91%) 14.19 kB → 13.92 kB
packages/loot-core/src/shared/rules.ts 📉 -213 B (-2.52%) 8.25 kB → 8.04 kB
packages/loot-core/src/server/api.ts 📉 -538 B (-2.62%) 20.03 kB → 19.5 kB
packages/loot-core/src/server/migrate/migrations.ts 📉 -132 B (-3.09%) 4.17 kB → 4.05 kB
packages/loot-core/src/server/importers/ynab4.ts 📉 -829 B (-6.13%) 13.21 kB → 12.4 kB
packages/loot-core/migrations/1722717601000_reports_move_selected_categories.js 🔥 -1.76 kB (-100%) 1.76 kB → 0 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
kcab.worker.js 1.14 MB → 1.14 MB (+821 B) +0.07%

Smaller

No assets were smaller

Unchanged

No assets were unchanged

@Midgetwombat Midgetwombat changed the title [WIP] Pay Distribution Template - PR Replacemet for #3078 Pay Distribution Template - PR Replacement for #3078 Aug 2, 2024
@Midgetwombat
Copy link
Author

I just keep making a mess of this so im just going to pull the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant