Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ (typescript) moving account component to TS #3311

Merged
merged 4 commits into from
Sep 3, 2024

Conversation

MatissJanis
Copy link
Member

@actual-github-bot actual-github-bot bot changed the title ♻️ (typescript) moving account component to TS [WIP] ♻️ (typescript) moving account component to TS Aug 24, 2024
Copy link

netlify bot commented Aug 24, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit fe4389e
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/66d7555c17bc7c0008cb21da
😎 Deploy Preview https://deploy-preview-3311.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Aug 24, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 5.21 MB → 5.21 MB (-1 B) -0.00%
Changeset
File Δ Size
src/components/accounts/Account.tsx 🆕 +43.27 kB 0 B → 43.27 kB
package.json 📈 +30 B (+0.94%) 3.11 kB → 3.14 kB
src/hooks/useSelected.tsx 📈 +5 B (+0.07%) 7.44 kB → 7.45 kB
src/components/accounts/Account.jsx 🔥 -43.3 kB (-100%) 43.3 kB → 0 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 3.25 MB → 3.25 MB (+35 B) +0.00%

Smaller

Asset File Size % Changed
static/js/wide.js 224.49 kB → 224.46 kB (-36 B) -0.02%

Unchanged

Asset File Size % Changed
static/js/usePreviewTransactions.js 1.59 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/AppliedFilters.js 21.01 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/narrow.js 77.58 kB 0%
static/js/ReportRouter.js 1.49 MB 0%

Copy link
Contributor

github-actions bot commented Aug 24, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.19 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.19 MB 0%

@MatissJanis MatissJanis changed the title [WIP] ♻️ (typescript) moving account component to TS ♻️ (typescript) moving account component to TS Aug 24, 2024
MikesGlitch
MikesGlitch previously approved these changes Aug 26, 2024
@MatissJanis MatissJanis merged commit 5cfa2cf into master Sep 3, 2024
19 checks passed
@MatissJanis MatissJanis deleted the matiss/ts-account branch September 3, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants