🐛 (bank-sync) revert bank-sync status indicator change

[MatissJanis]

In #3540 I was attempting to fix the status indicator for initial bank-sync operation. Unfortunately, this change has made things slightly worse. Sometimes the "loading" state for the initial bank-sync comes up, but then never goes away. I have not been able to figure out WHY. But arguably having no loading state is better than a forever-loading state, so reverting my original patch until I figure out a better solution.

[netlify]

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	40be40a
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/67194bcc4ff3b80008f71eda
😎 Deploy Preview	https://deploy-preview-3720.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
9	5.32 MB → 5.32 MB (-204 B)	-0.00%

Changeset

File	Δ	Size
home/runner/work/actual/actual/packages/loot-core/src/client/actions/account.ts	📉 -204 B (-4.06%)	4.91 kB → 4.71 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset	File Size	% Changed
static/js/index.js	3.33 MB → 3.33 MB (-204 B)	-0.01%

Unchanged

Asset	File Size	% Changed
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/narrow.js	82.57 kB	0%
static/js/usePreviewTransactions.js	1.64 kB	0%
static/js/AppliedFilters.js	21.3 kB	0%
static/js/wide.js	232.12 kB	0%
static/js/ReportRouter.js	1.51 MB	0%

[github-actions]

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.27 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.27 MB	0%

[coderabbitai]

Walkthrough

The pull request introduces changes to the linkAccount and linkAccountSimpleFin functions within the packages/loot-core/src/client/actions/account.ts file. The primary modification involves the removal of conditional checks for the upgradingId parameter in both functions. Previously, if an upgradingId was present, these functions would dispatch setAccountsSyncing with an array that included the upgradingId. By eliminating this dispatch, the control flow is simplified during the account linking process. This change may influence how account syncing is managed without altering any other aspects of logic, error handling, or control flow within the affected functions.

Possibly related PRs

• 🐛 (bank-sync) fix initial sync - close modal stack, show loading indicators #3540: This PR modifies the linkAccount function in the same file as the main PR, specifically addressing the control flow related to account linking, which is directly relevant to the changes made in the main PR.

Suggested labels

:sparkles: Merged

Suggested reviewers

• matt-fidd
• youngcw

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 34f3cca and 40be40a.

⛔ Files ignored due to path filters (1)

• upcoming-release-notes/3720.md is excluded by !**/*.md

📒 Files selected for processing (1)

• packages/loot-core/src/client/actions/account.ts (0 hunks)

💤 Files with no reviewable changes (1)

• packages/loot-core/src/client/actions/account.ts

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.