Fix "Name" field being in wrong colour in Schedules page

[aappaapp]

Fixed "None" not being in the disabled colour.

Original behaviour

[netlify]

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	72e5f5c
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/671cb19616a125000889a2ba
😎 Deploy Preview	https://deploy-preview-3739.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
9	5.32 MB → 5.32 MB (-7 B)	-0.00%

Changeset

File	Δ	Size
src/components/schedules/SchedulesTable.tsx	📉 -7 B (-0.06%)	10.84 kB → 10.84 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset	File Size	% Changed
static/js/index.js	3.33 MB → 3.33 MB (-7 B)	-0.00%

Unchanged

Asset	File Size	% Changed
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/usePreviewTransactions.js	1.64 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/AppliedFilters.js	21.3 kB	0%
static/js/narrow.js	82.57 kB	0%
static/js/wide.js	232.16 kB	0%
static/js/ReportRouter.js	1.5 MB	0%

[github-actions]

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.27 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.27 MB	0%

[coderabbitai]

Walkthrough

The pull request introduces modifications to the SchedulesTable.tsx component within the desktop client application. Key changes include an update to the rendering logic, specifically in the renderSchedule function, where the condition for checking the schedule name has been simplified from using == null to a negation check (!schedule.name). This adjustment enhances the clarity of the code without changing its functionality.

Additionally, the renderItem function has been refined to improve the display of completed schedules. While the logic for rendering the "Show completed schedules" row remains unchanged, the overall structure and readability of the code have been enhanced. The renderSchedule function continues to manage the rendering of individual schedule items, retaining its original functionality while benefiting from clearer conditional checks.

There are no changes to the declarations of exported or public entities in this update. The overall control flow and error handling mechanisms within the component remain intact, ensuring that its operational integrity is preserved.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between f25dc1f and 72e5f5c.

⛔ Files ignored due to path filters (1)

• upcoming-release-notes/3739.md is excluded by !**/*.md

📒 Files selected for processing (1)

• packages/desktop-client/src/components/schedules/SchedulesTable.tsx (1 hunks)

🔇 Additional comments (2)

packages/desktop-client/src/components/schedules/SchedulesTable.tsx (2)

286-286: LGTM: Color styling fix correctly implemented.

The change properly applies the disabled text color using theme.buttonNormalDisabledText when the schedule name is empty, fixing the visual inconsistency mentioned in the PR.

---

286-286: Verify the impact of the condition change.

The condition has been changed from == null to !schedule.name, which could affect how empty string names are handled. Please verify that this change doesn't introduce any unintended side effects for schedules with empty string names.

✅ Verification successful

The condition change from == null to !schedule.name is safe and consistent with the codebase

Based on the evidence:

1. The ScheduleEntity interface shows name is an optional string property (name?: string)
2. All other usages in the codebase handle schedule.name consistently:
   • The UI shows 'None' when name is falsy (schedule.name ? schedule.name : t('None'))
   • Empty names are treated as null in the backend (schedule.name = null)
   • Other UI components handle empty names gracefully (schedule.name || '')

The change to !schedule.name is actually more idiomatic as it correctly handles both null and empty string cases, which aligns with how the rest of the codebase treats schedule names.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for any tests or code that might be setting schedule names to empty string
rg -g '!*.{log,svg,lock}' -l 'schedule.*name.*=.*""' .
rg -g '!*.{log,svg,lock}' -l "schedule.*name.*=''" .

# Search for any validation or schema definitions for schedule names
rg -g '!*.{log,svg,lock}' 'schedule.*schema' -A 5 -B 5

Length of output: 174

---

Script:

#!/bin/bash
# Let's check the actual implementation and usage of schedule.name
ast-grep --pattern 'schedule.name'

# Let's also check for any type definitions or interfaces related to schedules
rg -g '*.ts' -g '*.tsx' 'interface.*Schedule' -A 10 -B 2

# Let's see the context around this condition in the file
rg -g '*.ts' -g '*.tsx' '!schedule.name.*\?' -A 3 -B 3

Length of output: 7067

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[MatissJanis]

Thanks