Bincode #6
Open
Bincode #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Changed database key serialization from manual methods to using bincode with the big_endian and fixint_encoding options. This is bitwise-identical to the original keys, but less verbose. 2. Changed other manual conversions of vectors to fixed-size arrays to using the clone_from_slice function. This can probably be done less verbosely as well.
Changed other manual conversions of vectors to fixed-size arrays to using the clone_from_slice function. This can probably be done less verbosely as well, probably using bincode.
Changed database key serialization from manual methods to using bincode with the big_endian and fixint_encoding options. This is bitwise-identical to the original keys, but less verbose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.