Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Upgrade Library Versions and Python Version #187

Merged
merged 13 commits into from
Aug 30, 2024
Merged

feat: Upgrade Library Versions and Python Version #187

merged 13 commits into from
Aug 30, 2024

Conversation

Lookatator
Copy link
Member

@Lookatator Lookatator commented Aug 26, 2024 •
edited
Loading

  • Moving from python 3.9 to python 3.10
  • Upgrade all library versions in requirements.txt and setup.py
  • Add option to install QDax with pip install qdax[cuda12] to install jax[cuda12] directly.
  • Remove DM-Haiku cause it is now deprecated.
  • jax.tree_map has been replaced with jax.tree_util.tree_map everywhere to avoid Deprecation Warnings.

Remaining TODOs

  • Test that notebooks and example are still working
  • Add instructions for pip install qdax[cuda12] in README
  • Fix jumanji test observations computation

Checks

  • a clear description of the PR has been added
  • N/A sufficient tests have been written
  • N/A relevant section added to the documentation
  • N/A example notebook added to the repo
  • N/A clean docstrings and comments have been written
  • if any issue/observation has been discovered, a new issue has been opened

Future improvements

  • Address remaining warnings we get while running pytests.
  • Add automatic pytest for notebooks (and maybe other examples) in CI.

@Lookatator Lookatator added the enhancement New feature or request label Aug 26, 2024
@Lookatator Lookatator self-assigned this Aug 26, 2024
@Lookatator Lookatator marked this pull request as ready for review August 28, 2024 09:14
@Lookatator Lookatator merged commit f2c6311 into develop Aug 30, 2024
5 checks passed
This was referenced Aug 30, 2024
Closed
Merged
@Lookatator Lookatator deleted the feat/upgrade-versions branch September 1, 2024 21:15
Lookatator added a commit that referenced this pull request Sep 6, 2024
@Lookatator @maxencefaldor
@hannah-jan @felixchalumeau
Release 0.4.0 (#183)
8c9d2ec 
* feat(algo): add DCG-MAP-Elites whose most recent version is called DCRL-ME (#167)
* fix: Fix pareto dominance definition to account for solutions which have the same fitness values along one axis (#174)
* docs(contribution): clarify contribution process (#171)
* feat: Upgrade Library Versions and Python Version (#187)

---------

Co-authored-by: Maxence Faldor <[email protected]>
Co-authored-by: Hannah Janmohamed <[email protected]>
Co-authored-by: Felix Chalumeau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxencefaldor maxencefaldor maxencefaldor approved these changes

Assignees

@Lookatator Lookatator

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lookatator @maxencefaldor