Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare version 1.0.0 #131

Merged
merged 6 commits into from
May 31, 2024
Merged

prepare version 1.0.0 #131

merged 6 commits into from
May 31, 2024

Conversation

adbar
Copy link
Owner

@adbar adbar commented May 27, 2024

Everyone OK with that @juanjoDiaz @osma ?

@adbar adbar linked an issue May 27, 2024 that may be closed by this pull request
Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.38%. Comparing base (546ab7e) to head (bac57f1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #131   +/-   ##
=======================================
  Coverage   96.38%   96.38%           
=======================================
  Files          33       33           
  Lines         581      581           
=======================================
  Hits          560      560           
  Misses         21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dunedan
Copy link
Contributor

Dunedan commented May 29, 2024

The first paragraph of the "Advanced usage via classes" section in the README.md should probably be deleted as part of a 1.0 release as well:

simplemma/README.md

Lines 222 to 224 in 546ab7e

*The following classes will be made available in the next version. To
start using them, install the latest version from the git repository.
The full docs are available [here](https://adbar.github.io/simplemma/)*

@osma
Copy link
Contributor

osma commented May 30, 2024

I haven't tested the codebase in a while (still using 0.9.1 in Annif) but I will try to do so. Not before next week though.

@adbar adbar merged commit 6860df6 into main May 31, 2024
16 checks passed
@adbar adbar deleted the prepare_v1 branch May 31, 2024 10:21
@adbar
Copy link
Owner Author

adbar commented May 31, 2024

I guess it was about time... Things should be pretty stable, if there are problems we can just fix them and release a new version.

@osma
Copy link
Contributor

osma commented May 31, 2024

Excellent news & great work @adbar ! You are right, no point in delaying a release further if there are no known bad issues.

@juanjoDiaz
Copy link
Collaborator

I'm a bit late but glad to see this out.
As you mentioned, we can always do more release.

One thing that I'm missing is to add the documentation: https://adbar.github.io/simplemma
To the repo front page so it's accesible to everyone 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plans for simplemma 1.0 release?
4 participants