Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version #111

Merged
merged 2 commits into from
Dec 2, 2023
Merged

Update version #111

merged 2 commits into from
Dec 2, 2023

Conversation

peno64
Copy link
Collaborator

@peno64 peno64 commented Nov 28, 2023

No description provided.

@michaelarnauts
Copy link
Contributor

Hey @peno64
The way how the packaging was setup is that the repository is for Leia, and we modify the addon.xml when we package for Matrix. See https://github.com/add-ons/service.iptv.manager/blob/master/Makefile#L86

Now, I have changed this a while ago for the VTM Go and my other addons so the repository is Matrix, and we modify during packaging for Leia. See my changes here: https://github.com/add-ons/plugin.video.vtm.go/pull/318/files

Around the release of nexus, I have removed the packaging for Leia all together. See add-ons/plugin.video.vtm.go#364

I also have to say that I'm no longer using Kodi, so the changes of me looking into this are very low. I do want to make you admin for this project if you want.

@peno64
Copy link
Collaborator Author

peno64 commented Nov 30, 2023

@michaelarnauts
It is a pitty that these great addons are no longer under your wings.
I will try to maintain what I can.
How are changes then pushed to the kodi repo or is this done automatically?

@michaelarnauts
Copy link
Contributor

@michaelarnauts It is a pitty that these great addons are no longer under your wings. I will try to maintain what I can. How are changes then pushed to the kodi repo or is this done automatically?

It used to be done automatically with tags, but due to some issues, I have changed this to be manually for now. But I made some scripts to help. Feel free to send me an email and i'll try to give a bit of info on how I was doing the releases.

@peno64 peno64 merged commit bba8792 into add-ons:master Dec 2, 2023
0 of 11 checks passed
@michaelarnauts
Copy link
Contributor

@peno64 check the tests. You shouldn't have merged this. The addon.xml is wrong now in the releases.

@peno64
Copy link
Collaborator Author

peno64 commented Dec 2, 2023

@michaelarnauts
Sorry. I will revert

@peno64
Copy link
Collaborator Author

peno64 commented Dec 2, 2023

@michaelarnauts
Well I fixed addon.xml but still all tests fail. Must be for another reason.

@michaelarnauts
Copy link
Contributor

I think the best is to look at the mentioned vtm go merge request, and do the same changes here. You can then use make build to create the zip for matrix and Leia.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants