Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update he.yaml #1594

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update he.yaml #1594

wants to merge 3 commits into from

Conversation

idanhazan
Copy link

PR Summary:

This PR includes three types of changes:

  • Completion of Missing Translations: Added translations for previously missing content.
  • Content Corrections: Corrected translations to better reflect the intended meaning.
  • Language Direction Adjustments (RTL): Fixed issues related to the right-to-left (RTL) text direction to ensure proper display and readability.

Please review the changes and let me know if there are any additional adjustments needed. Thank you!

@adityatelange
Copy link
Owner

@eisraeli @RealA10N requesting your review

@idanhazan
Copy link
Author

idanhazan commented Sep 7, 2024

I had two additional questions:

  1. Should we use "דקה 1" instead of "דקה אחת" to maintain consistency with the English version, which uses "1 min" rather than "one min"?

  2. Should we use "מילה 1" or "מילה אחת" instead of just "מילה" to align with the format used for minutes?

In terms of correct Hebrew, it is preferable to use the phrases: "דקה אחת" and "מילה אחת"

@RealA10N
Copy link
Contributor

RealA10N commented Sep 7, 2024

IMO there is no need to enforce consistency across languages at this micro level: as long as the meaning is consistent, the exact wording should be in accordance with the laws of the local language.

So I suggest:

מילה אחת

For "1 word", and,

דקה אחת

For "1 min".

Other than that, LGTM!

i18n/he.yaml Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Sep 7, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants