Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace xs:dateType with xs:dateTime #461

Open
wants to merge 1 commit into
base: IDTA-01001-3-1_working
Choose a base branch
from

Conversation

sebbader-sap
Copy link
Contributor

@sebbader-sap sebbader-sap commented Aug 1, 2024

xs:dateType does not exist, neither in XML Schema 1.0 or 1.1.
Furthermore, XML Schema Datatypes 1.1 also know the xs:dateTime, therefore, there is no need to switch to xs:dateTimeStamp.

closes #467

@sebbader-sap
Copy link
Contributor Author

I have no clue why Github thinks that I am also adding the image55.png with this PR...

|xsd |https://www.w3.org/TR/xmlschema-2/#dateType[dateType] |Date and time with or without time zone |"2000-01-01T14:23:00", +
"2000-01-01T14:23:00.66372+14:00"footnote:[Corresponds to xs:dateTimeStamp in XML Schema 1.1]
|xsd |https://www.w3.org/TR/xmlschema-2/#dateTime[dateTime] |Date and time with or without time zone |"2000-01-01T14:23:00", +
"2000-01-01T14:23:00.66372+14:00"footnote:[Corresponds to https://www.w3.org/TR/xmlschema11-2/#dateTime[xs:dateTime] in XML Schema 1.1]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"2000-01-01T14:23:00.66372+14:00"footnote:[Corresponds to https://www.w3.org/TR/xmlschema11-2/#dateTime[xs:dateTime] in XML Schema 1.1]
"2000-01-01T14:23:00.66372+14:00"footnote:[Corresponds to https://www.w3.org/TR/xmlschema-2/#dateTime[xs:dateTime] in XML Schema 1.0]

Copy link
Collaborator

@BirgitBoss BirgitBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a bug. I corrected the footnote, we use schema 1.0, not schema 1.1

@BirgitBoss BirgitBoss added bug Something isn't working accepted accepted in principle to be fixed labels Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted accepted in principle to be fixed bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants