Fix/277 - Fixes issues with the iPad Retina's Emulator's Layout mode not being reflected #279
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(767px -> 768px -- as the cq:responsive breakpoint is set to 768)
https://experienceleague.adobe.com/docs/experience-manager-64/administering/operations/configuring-responsive-layout.html?lang=en
Description
When selecting the iPad Retina emulator in Layout Mode in PageEditor (which is width 768px) layout mode does not work (it snaps back).
The reason for this is as follows:
So, when iPad Retina emulator is selected, the "phone" breakpoint is resolved, and the Layout changes are persisted to the component's
cq:responsive/phone
node (since iPad Retina's 768px <= Template's cq:responsive/breakpoints/phone@width=768However, the AEM Grid CSS for the "phone" breakpoint reacts when the viewport is <=767px, which 768px is not, therefor the persisted values on the component's
cq:responsive/phone
node are being ignored.Aligning the CSS's max-width and the breakpoints max-width both to 768px resolves this conflict.
We may want to fix-up this piece of WKND actually, as only define 2 breakpoints (phone, tablet) and an implicit 3rd (default, which is anything > tablet), however the emulator's WKND ships do not let you differentiate between tablet and desktop, making it somewhat awkward/confusing.
Motivation and Context
See #277
How Has This Been Tested?
Tested on AEM 6.5.7.
Screenshots (if appropriate):
Types of changes
Checklist: