Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support passing custom AbortSignal #106

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support passing custom AbortSignal #106

wants to merge 2 commits into from

Conversation

creatorrr
Copy link

@creatorrr creatorrr commented Aug 6, 2022 •
edited
Loading

Description

Support passing custom AbortSignal
Fixes #104

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@creatorrr creatorrr changed the title Patch 1 Support passing custom AbortSignal Aug 6, 2022
@creatorrr
Copy link
Author

I'd be happy to update the docs etc. but is this the right direction for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support passing custom AbortSignal (would need to disable socketTimeout if signal passed)
1 participant
@creatorrr