Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for webpack and node-fetch #36

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix for webpack and node-fetch #36

wants to merge 2 commits into from

Conversation

ParcelSolutions
Copy link

@ParcelSolutions ParcelSolutions commented Oct 29, 2020

node-fetch/node-fetch#450

Description

use default in require of node-fetch, so it will work with webpack
webpack is often used to create openwhisk builds.

see for details:
node-fetch/node-fetch#450

Fixes # (issue)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@tmathern tmathern requested review from tmathern and removed request for tmathern February 2, 2021 23:08
@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #36 (3dd50c7) into master (4161e43) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #36   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           68        68           
=========================================
  Hits            68        68           
Impacted Files Coverage Δ
index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4161e43...3dd50c7. Read the comment docs.

Copy link
Contributor

@alexkli alexkli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this is a bit safer (in case we change the node-fetch version in package.json and the .default is no longer there)?

https://github.com/Flagsmith/flagsmith-nodejs-client/pull/21/files#diff-537b33488a6027f3f9f309df24d9af4c6819c635cdae1d650245a259e4f8e335R1

@alexkli alexkli added this to the v3 milestone Apr 28, 2022
@alexkli alexkli added the contribution PR from an external contributor label Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution PR from an external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants